feat: use Toolbar and ToolbarSidebar from analytics #2358

HendrikThePendric · 2023-05-30T09:23:54Z

Implements DHIS2-15167

Requires dhis2/analytics#1478

Key features

Updated toolbar with hover menu menu

TODO

Update @dhis2/analytics once released.
Update tests for the new implementation

Screenshots

dhis2-bot · 2023-06-20T13:27:47Z

🚀 Deployed on https://pr-2358--dhis2-data-visualizer.netlify.app

cypress · 2023-06-20T15:04:00Z

Passing run #2311 ↗︎

0	629	1	0	0

Details:

Merge `6913f7c` into `20efd02`...
Project: Data Visualizer App	Commit: `379f44f614 ℹ️`
Status: Passed	Duration: 16:02 💡
Started: Aug 9, 2023 9:08 AM	Ended: Aug 9, 2023 9:24 AM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

package.json

HendrikThePendric · 2023-06-27T14:43:13Z

src/components/VisualizationTypeSelector/styles/VisualizationTypeSelector.module.css

+.arrowIcon.listIsOpen {
+    transform: rotate(180deg);
+}


I'm now rotating the arrow-icon when the list is open, as we do on select elements to give more visual feedback to the user and make the UI more consistent.

HendrikThePendric · 2023-06-27T14:45:42Z

src/components/VisualizationTypeSelector/styles/VisualizationTypeSelector.module.css

    font-size: 14px;
+    padding-top: 1px;


This padding is problematic. I'm not actually sure if we should keep this change. I LL I did a similar fix, which does make sense because there we always show the same icon. However, in DV each viz-type comes with its own icon. For some icons things now look better aligned but others actually look worse....

So in that case I would recommend to simply keep the text in the actual vertical center instead of pushing it 1px down.

@cooper-joe @janhenrikoverland @martinkrulltott

* feat: use Toolbar and ToolbarSidebar from analytics * feat: use UpdateButton and HoverMenubar from analytics * feat: update download menu to use hovermenu components from analytics * feat: use hover menu components from analytics for options menu * feat: use interpretations button from analytics * chore: update pot file * chore: upgrade @dhis2/analytics to latest * chore: fix typo in component name * fix: adjust e2e element slectors * chore: fix missing and redundant imports * chore: fix odd linter error which only fires on ci * fix: adjust data test name * chore: fix lines e2e test * fix: adjust closeFileMenuWithClick command * chore: fix failing legens e2e test * chore: fix legend e2e test even better * chore: fix scatter e2e * chore: fix icon e2e * chore: fix start e2e * chore: clean up unused imports * fix: remove divider from plain data source submenu * chore: upgrade @dhis2/analytics to get toolbar UI improvements * fix: tweak viz type selector styles to match toolbar * chore: remove yarn start command which was only used for development * chore: upgrade analytics to get decreased padding * fix: ensure `MenuSectionHeader` is `dense` when in `HoverMenuBar` --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com>

@dhis2-bot

* chore: run workflow release job on tags as well (#2386) Tag builds were not triggering creation of corresponding branch in d2-ci repo. The core apps-to-bundle depends on these. * test: add Cypress tests for SV icon (DHIS2-10496) (#2372) * fix(translations): sync translations from transifex (dev) Automatically merged. * fix(translations): sync translations from transifex (dev) Automatically merged. * fix(translations): sync translations from transifex (dev) Automatically merged. * test: more tests for custom calculations (DHIS2-13871) (#2287) * test: rename AO-title to titlebar (DHIS2-15063) (#2435) * fix(translations): sync translations from transifex (dev) Automatically merged. * chore: run nightly at 6:20 instead of 2:20 to avoid concurrently running with instances reset (#2500) * test: extend timeout after delete has been triggered (#2499) * fix: inject style in props passed to VisualizationPlugin (DHIS2-15126) (#2322) * fix: inject style in props passed to VisualizationPlugin style is used to compute the correct width when toggling the legend panel in dashboard. style is not passed in props from dashboard because doing so can cause re-rendering of the whole iframe tag which causes refetching of the plugin and everything else (analytics included). * refactor: move the size logic from the plugin wrapper This is because eventually the PluginWrapper component will be replaced by the generic one from app-platform. If possible all custom logic should not be put in other components at the app level. * fix: observe size changes for legend positioning * refactor: rename const for clarity It's a callback ref, not a normal ref. --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> Co-authored-by: Martin <martin@moid.se> * chore: increase cypress default timeout for DOM activity (#2549) * chore: manually bump deps (#2543) * chore: advance the schedule for the nightly run (#2575) * test: prevent test names from being dynamic (#2576) * chore: disable the scheduled nightly test run (#2602) The servers are currently slow and there will be very little frontend or backend activity during July 2023 * chore: upgrade cypress to v12 and adjust project to it * chore: remove videos * chore: gitignore cypress videos * chore: switch test server to debug (test.e2e is broken/slow) * chore: revert the test server changes and move to a separate PR * test: comment out icon tests for currently unsupported types * test: skip legend test while data element icons are unsupported * fix(translations): sync translations from transifex (dev) Automatically merged. * feat: use Toolbar and ToolbarSidebar from analytics (#2358) * feat: use Toolbar and ToolbarSidebar from analytics * feat: use UpdateButton and HoverMenubar from analytics * feat: update download menu to use hovermenu components from analytics * feat: use hover menu components from analytics for options menu * feat: use interpretations button from analytics * chore: update pot file * chore: upgrade @dhis2/analytics to latest * chore: fix typo in component name * fix: adjust e2e element slectors * chore: fix missing and redundant imports * chore: fix odd linter error which only fires on ci * fix: adjust data test name * chore: fix lines e2e test * fix: adjust closeFileMenuWithClick command * chore: fix failing legens e2e test * chore: fix legend e2e test even better * chore: fix scatter e2e * chore: fix icon e2e * chore: fix start e2e * chore: clean up unused imports * fix: remove divider from plain data source submenu * chore: upgrade @dhis2/analytics to get toolbar UI improvements * fix: tweak viz type selector styles to match toolbar * chore: remove yarn start command which was only used for development * chore: upgrade analytics to get decreased padding * fix: ensure `MenuSectionHeader` is `dense` when in `HoverMenuBar` --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> * Merge pull request #2613 from dhis2/chore/upgrade-cypress-to-v12 chore: upgrade cypress to v12 * chore: run nightly at 6:20 to avoid concurrently running with instances reset (#2500) * test: extend timeout after delete has been triggered (#2499) * fix: inject style in props passed to VisualizationPlugin (DHIS2-15126) (#2322) * fix: inject style in props passed to VisualizationPlugin style is used to compute the correct width when toggling the legend panel in dashboard. style is not passed in props from dashboard because doing so can cause re-rendering of the whole iframe tag which causes refetching of the plugin and everything else (analytics included). * refactor: move the size logic from the plugin wrapper This is because eventually the PluginWrapper component will be replaced by the generic one from app-platform. If possible all custom logic should not be put in other components at the app level. * fix: observe size changes for legend positioning * refactor: rename const for clarity It's a callback ref, not a normal ref. --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> Co-authored-by: Martin <martin@moid.se> * chore: increase cypress default timeout for DOM activity (#2549) * chore: manually bump deps (#2543) * chore: advance the schedule for the nightly run (#2575) * test: prevent test names from being dynamic (#2576) * chore: disable the scheduled nightly test run (#2602) Servers are currently slow. Will be little activity during July 2023. * chore: upgrade cypress to v12 and adjust project to it * chore: remove videos * chore: gitignore cypress videos * chore: switch test server to debug (test.e2e is broken/slow) * chore: revert the test server changes and move to a separate PR * test: comment out icon tests for currently unsupported types * test: skip legend test while data element icons are unsupported * fix(translations): sync translations from transifex (dev) Automatically merged. * feat: use Toolbar and ToolbarSidebar from analytics (#2358) * feat: use Toolbar and ToolbarSidebar from analytics * feat: use UpdateButton and HoverMenubar from analytics * feat: update download menu to use hovermenu components from analytics * feat: use hover menu components from analytics for options menu * feat: use interpretations button from analytics * chore: update pot file * chore: upgrade @dhis2/analytics to latest * chore: fix typo in component name * fix: adjust e2e element slectors * chore: fix missing and redundant imports * chore: fix odd linter error which only fires on ci * fix: adjust data test name * chore: fix lines e2e test * fix: adjust closeFileMenuWithClick command * chore: fix failing legens e2e test * chore: fix legend e2e test even better * chore: fix scatter e2e * chore: fix icon e2e * chore: fix start e2e * chore: clean up unused imports * fix: remove divider from plain data source submenu * chore: upgrade @dhis2/analytics to get toolbar UI improvements * fix: tweak viz type selector styles to match toolbar * chore: remove yarn start command which was only used for development * chore: upgrade analytics to get decreased padding * fix: ensure `MenuSectionHeader` is `dense` when in `HoverMenuBar` --------- Co-authored-by: Jan Henrik Øverland <janhenrik.overland@gmail.com> * Merge pull request #2613 from dhis2/chore/upgrade-cypress-to-v12 chore: upgrade cypress to v12 --------- Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org> Co-authored-by: Martin <martin@moid.se> Co-authored-by: @dhis2-bot <apps@dhis2.org> Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org> Co-authored-by: HendrikThePendric <hendrik@dhis2.org> Co-authored-by: Hendrik de Graaf <HendrikThePendric@users.noreply.github.com>

HendrikThePendric marked this pull request as draft May 30, 2023 09:24

HendrikThePendric mentioned this pull request May 30, 2023

feat: toolbar UI update with hoverable menu dhis2/analytics#1478

Merged

2 tasks

HendrikThePendric mentioned this pull request Jun 20, 2023

feat: toolbar UI update with hoverable menu (#1478) dhis2/analytics#1509

Merged

2 tasks

HendrikThePendric force-pushed the DHIS2-15167-DV-toolbar-update branch from b00897c to 7bf899a Compare June 20, 2023 12:43

dhis2-bot temporarily deployed to netlify June 20, 2023 13:27 Inactive

HendrikThePendric marked this pull request as ready for review June 20, 2023 13:38

HendrikThePendric force-pushed the DHIS2-15167-DV-toolbar-update branch from f5feb15 to e4ffafe Compare June 20, 2023 13:38

HendrikThePendric added the On hold label Jun 20, 2023

dhis2-bot temporarily deployed to netlify June 20, 2023 13:42 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 09:58 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 10:25 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 10:29 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 11:52 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 13:31 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 13:46 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 14:36 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 14:59 Inactive

dhis2-bot temporarily deployed to netlify June 22, 2023 15:41 Inactive

HendrikThePendric force-pushed the DHIS2-15167-DV-toolbar-update branch from 3f79113 to df05a0e Compare June 22, 2023 16:19

dhis2-bot temporarily deployed to netlify June 22, 2023 16:23 Inactive

edoardo reviewed Jun 23, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

edoardo approved these changes Jun 23, 2023

View reviewed changes

martinkrulltott assigned HendrikThePendric Jun 26, 2023

martinkrulltott added the Analytics Team Testing label Jun 27, 2023

HendrikThePendric mentioned this pull request Jun 27, 2023

fix: various issues related to the new toolbar dhis2/analytics#1522

Merged

dhis2-bot temporarily deployed to netlify June 27, 2023 14:36 Inactive

HendrikThePendric commented Jun 27, 2023

View reviewed changes

HendrikThePendric added 20 commits July 3, 2023 16:30

chore: upgrade @dhis2/analytics to latest

3fc8863

chore: fix typo in component name

cd0614e

fix: adjust e2e element slectors

2191f3c

chore: fix missing and redundant imports

72a97e9

chore: fix odd linter error which only fires on ci

a2c29ed

fix: adjust data test name

1d5d8cd

chore: fix lines e2e test

c4ef597

fix: adjust closeFileMenuWithClick command

a0aeadb

chore: fix failing legens e2e test

3fab280

chore: fix legend e2e test even better

ad2b972

chore: fix scatter e2e

c956c6c

chore: fix icon e2e

e2653ef

chore: fix start e2e

ea64563

chore: clean up unused imports

506153b

fix: remove divider from plain data source submenu

b5e9b94

chore: upgrade @dhis2/analytics to get toolbar UI improvements

fa76f45

fix: tweak viz type selector styles to match toolbar

a4cf574

chore: remove yarn start command which was only used for development

3e96e34

chore: upgrade analytics to get decreased padding

89f9932

fix: ensure MenuSectionHeader is dense when in HoverMenuBar

9e044c1

HendrikThePendric force-pushed the DHIS2-15167-DV-toolbar-update branch from 74f3921 to 9e044c1 Compare July 3, 2023 14:30

dhis2-bot temporarily deployed to netlify July 3, 2023 14:35 Inactive

Merge branch 'dev' into DHIS2-15167-DV-toolbar-update

6913f7c

dhis2-bot temporarily deployed to netlify August 9, 2023 09:03 Inactive

HendrikThePendric merged commit 99d5e5e into dev Aug 9, 2023
12 checks passed

HendrikThePendric deleted the DHIS2-15167-DV-toolbar-update branch August 9, 2023 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use Toolbar and ToolbarSidebar from analytics #2358

feat: use Toolbar and ToolbarSidebar from analytics #2358

HendrikThePendric commented May 30, 2023 •

edited

Loading

dhis2-bot commented Jun 20, 2023 •

edited

Loading

cypress bot commented Jun 20, 2023 •

edited

Loading

HendrikThePendric Jun 27, 2023

HendrikThePendric Jun 27, 2023 •

edited

Loading

feat: use Toolbar and ToolbarSidebar from analytics #2358

feat: use Toolbar and ToolbarSidebar from analytics #2358

Conversation

HendrikThePendric commented May 30, 2023 • edited Loading

Key features

TODO

Screenshots

dhis2-bot commented Jun 20, 2023 • edited Loading

cypress bot commented Jun 20, 2023 • edited Loading

Passing run #2311 ↗︎

HendrikThePendric Jun 27, 2023

Choose a reason for hiding this comment

HendrikThePendric Jun 27, 2023 • edited Loading

Choose a reason for hiding this comment

HendrikThePendric commented May 30, 2023 •

edited

Loading

dhis2-bot commented Jun 20, 2023 •

edited

Loading

cypress bot commented Jun 20, 2023 •

edited

Loading

HendrikThePendric Jun 27, 2023 •

edited

Loading