Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emoji-row): DLT-2248 display larger emoji and inline shortcode in emoji row tooltip #601

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

francisrupert
Copy link
Contributor

Display larger emoji and inline shortcode in emoji row tooltip

Why am I doing this on a Friday night before Christmas break? Sat on couch with the wife and teenage daughters, did this instead while they watched some schmaltzy Hallmark Christmas movie.

image

🛠️ Type Of Change

  • Feature

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2248

📖 Description

  • Display larger emoji
  • Display shortcode inline
  • BONUS: will make Custom Emojis more useful

This is effectively a simple prototype, so someone will need to take it over from me and update it correctly.

image

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

For all CSS changes:

  • I have used design tokens whenever possible.
  • I have considered how this change will behave on different screen sizes.
  • I have visually validated my change in light and dark mode.
  • I have used gap or flexbox properties for layout instead of margin whenever possible.

Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-601/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-601/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-601/

@tedgoas-dialpad
Copy link

@francisrupert Amazing. Love to see this, thanks for remembering!

Small ask: can we make the emoji reactions a bit larger too? Currently they're at 14px which is too small, even for standard emojis. Feels like 16px is the sweet spot.
Screenshot 2024-12-23 at 1 36 39 PM


Also can we make the light gray background any lighter? This also makes the emoji harder to read.

Check out Slack, with a slightly lighter gray and slightly larger image. Makes a big difference:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants