Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emoji-row): DLT-2248 display larger emoji and inline shortcode in emoji row tooltip #601

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

feat(emoji-row): DLT-2248 display larger emoji and inline shortcode in emoji row tooltip #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions packages/dialtone-vue2/recipes/conversation_view/emoji_row/emoji_row.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,41 @@
:key="reaction.unicodeOutput"
:reaction="reaction"
>
<!--
CONSIDERATION: on product side, content-class="d-wmx###"
can be adjusted to wider if more than X people.
Or even narrower if fewer.
-->
<dt-tooltip
class="d-recipe-emoji-row__tooltip"
content-class="d-wmx464"
content-class="d-wmx216"
sticky="popper"
:fallback-placements="['top', 'bottom']"
@shown="(shown) => emojiHovered(reaction, shown)"
>
<span aria-hidden="true">
<dt-emoji-text-wrapper size="200">
{{ reaction.tooltip }}
</dt-emoji-text-wrapper>
</span>
<!-- TODO: move CSS utilitites to emoji_row.less -->
<div
aria-hidden="true"
class="d-bar4 d-bgc-neutral-white d-p4 d-d-inline-block d-mt4 d-mb6"
>
<!-- TODO: will ultimately need to work for Custom Emojis, including animated. Presumably same size -->
<dt-emoji
:code="reaction.emojiUnicodeOrShortname"
size="800"
/>
</div>
<div>
Brad Paugh,
Julio Ortega,
Ignacio Ropolo,
Nina Repetto,
Francis Rupert,
and
you
<span class="d-fc-tertiary-inverted d-fw-normal">
reacted with :sparkling_heart:
</span>
</div>
<template #anchor="{ attrs }">
<dt-button
importance="clear"
Expand Down Expand Up @@ -52,12 +76,11 @@ import { REACTIONS_ATTRIBUTES } from './emoji_row_constants.js';
import { DtButton } from '../../../components/button';
import { DtTooltip } from '../../../components/tooltip';
import { DtEmoji } from '../../../components/emoji';
import { DtEmojiTextWrapper } from '../../../components/emoji_text_wrapper';

export default {
name: 'DtRecipeEmojiRow',

components: { DtTooltip, DtButton, DtEmoji, DtEmojiTextWrapper },
components: { DtTooltip, DtButton, DtEmoji },

mixins: [],

Expand Down
Loading