Merge branch 'feature/linting' of github.com:digicatapult/act-pot-che…

…ribsd into feature/linting

* 'feature/linting' of github.com:digicatapult/act-pot-cheribsd:
  Apply suggestions from code review

config.sh

@@ -10,8 +10,8 @@ if [ "$1" != '--url' ] || [ "$3" != '--token' ]; then
 fi
 
 # Generate a random string for the runner name, if using config.sh without variables
-export RANDOM
 RANDOM="$(LC_ALL=C tr -dc 'a-zA-Z0-9' < /dev/urandom | head -c 8)"
+export RANDOM
 . ${SCRIPTDIR}/check-envs.sh
 
 mkdir -p ${RUNNER_CONFIG_DIRECTORY}

flavours/github-act.sh

@@ -10,7 +10,7 @@ if [ "$NAME" = "FreeBSD" ]; then
     echo "FreeBSD update completed."
 fi
 
-if [ "$NAME" = "FreeBSD" ] || [ "$NAME" = "CheriBSD" ]; then
+if [ "$NAME" = "CheriBSD" ]; then
     echo "skipped freebsd-update for $NAME"
 fi