Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: remove deprecations from Ember 3/4 after upgrade to Ember 5 #13

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

tyb-talks
Copy link
Contributor

We've upgraded to Ember 5, so no need to track v3/4 deprecations.

Can be verified against https://github.com/ember-learn/deprecation-app/tree/main/content/ember/v5 (yes there's only 1).

@tyb-talks tyb-talks force-pushed the dev-remove-ember-3-4-deprecations branch from 5dbec6e to 7f68480 Compare March 14, 2024 03:40
@davidtaylorhq
Copy link
Member

Hmm I think the test failure is probably because we've silenced deprecate-implicit-route-model in core's deprecation-workflow config 🤔. Perhaps we should update the system spec to unsilence everything before triggering deprecations? Something like

page.execute_script <<~JS
  window.deprecationWorkflow.config.workflow.clear()
JS

Then I think it should work consistently even when we change core 🤞

@davidtaylorhq davidtaylorhq merged commit e545425 into main Mar 14, 2024
4 checks passed
@davidtaylorhq davidtaylorhq deleted the dev-remove-ember-3-4-deprecations branch March 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants