Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: remove deprecations from Ember 3/4 after upgrade to Ember 5 #13

Merged
merged 2 commits into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 1 addition & 81 deletions lib/deprecation_collector/list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,87 +3,7 @@
module DeprecationCollector
List =
# Ember deprecations (generated by `/list_ember_deprecations.rb`)
%w[
3-0-browser-support-policy
action.mouseenter-leave-move
application-controller.router-properties
argument-less-helper-paren-less-invocation
array.new-array-wrapper
array-observers
attrs-arg-access
autotracking.mutation-after-consumption
class-binding-and-class-name-bindings-in-templates
component-manager-string-lookup
component.mouseenter-leave-move
computed-property.override
computed-property.property
computed-property.volatile
deprecate-router-events
deprecated-run-loop-and-computed-dot-access
editions.classic
ember.built-in-components.import
ember.built-in-components.legacy-arguments
ember.built-in-components.legacy-attribute-arguments
ember.built-in-components.reopen
ember-component.is-visible
ember.component.reopen
ember-component.send-action
ember-console.deprecate-logger
ember-env.old-extend-prototypes
ember-glimmer.link-to.positional-arguments
ember-glimmer.with-syntax
ember-global
ember.globals-resolver
ember.link-to.disabled-when
ember-meta.descriptor-on-object
ember-metal.get-with-default
ember.partial
ember-polyfills.deprecate-merge
ember-routing.route-router
ember-runtime.deprecate-copy-copyable
ember-source-deprecation-without-for
ember-source-deprecation-without-since
ember-string.htmlsafe-ishtmlsafe
ember-string.loc
ember-string.prototype-extensions
ember-utils.try-invoke
events.inherited-function-listeners
events.remove-all-listeners
function-prototype-extensions.observes
function-prototype-extensions.on
function-prototype-extensions.property
getting-the-each-property
has-block-and-has-block-params
implicit-injections
jquery-apis
jquery-event
manager-capabilities.components-3-4
manager-capabilities.modifiers-3-13
meta-destruction-apis
object.alias-method
object.new-constructor
old-deprecate-method-paths
optional-feature.application-template-wrapper
optional-feature.jquery-integration
optional-feature.template-only-glimmer-components
remove-handler-infos
route-disconnect-outlet
route-render-template
routing.transition-methods
setting-on-hash
template-compiler.registerPlugin
this-property-fallback
transition-state
use-notifypropertychange-instead-of-propertywillchange-and-propertydidchange
deprecate-auto-location
deprecate-ember-error
ember-polyfills.deprecate-assign
ember-string.add-package
ember-string.from-ember-module
implicit-injections
deprecate-implicit-route-model
ember-views.curly-components.jquery-element
] +
%w[deprecate-implicit-route-model] +
# discourse deprecations
%w[
discourse.modal-controllers
Expand Down
2 changes: 1 addition & 1 deletion list_ember_deprecations.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

deprecation_ids = []

Dir.glob("deprecation-app/content/ember/{v3,v4,v5}/*.md") do |file|
Dir.glob("deprecation-app/content/ember/{v5}/*.md") do |file|
frontmatter = YAML.load_file(file)
display_id = frontmatter["displayId"] || File.basename(file, ".md")
deprecation_ids << display_id if display_id
Expand Down
5 changes: 4 additions & 1 deletion spec/system/deprecation_collector_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

logged_deprecations = []

test_deprecation_id = DeprecationCollector::List.first
test_deprecation_id = "fake-ember-deprecation"
DeprecationCollector::List.push(test_deprecation_id)

stub =
DeprecationCollector
Expand All @@ -32,5 +33,7 @@
try_until_success do
expect(logged_deprecations).to include(test_deprecation_id, "_other_discourse")
end
ensure
DeprecationCollector::List.push(test_deprecation_id)
end
end
Loading