Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Storage for builds #441

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Conversation

gw2princeps
Copy link
Member

@gw2princeps gw2princeps commented Apr 11, 2022

Changes / additions:

  • Saved results are permanently shown now; maybe this brings more attention to this feature.
  • A button to open the saved results manager was added
  • The manager allows a number of things:
    • Saving a character to the local storage
    • downloading characters
    • copying characters to the clipboard
    • a nice overview over all the saved builds :))
    • Renaming a character to keep track of own builds more easily

@cloudflare-workers-and-pages

This comment was marked as outdated.

@gw2princeps
Copy link
Member Author

This is ready in theory. One thing that is up for discussion is the handling of dual wielded weapons in the result tables. Since we can restore builds with a different option on dual/single wield, the table will bug out.

@marcustyphoon
Copy link
Collaborator

Hm. We could make the table always have 2 weapon rows and span them if you have a single weapon I guess. Looks kind of weird though. More advanced logic could do that if any build has 2 weapons maybe.

@marcustyphoon
Copy link
Collaborator

Small tweak: changed the JSON import to push builds into the persistent section rather than the temporary section. The other way around, the copied build name gets thrown away when you import it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants