Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Storage for builds #441

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
23231a6
feat: improve styling of saved section
gw2princeps Apr 10, 2022
c810501
fix: pointer cursor correct image
gw2princeps Apr 10, 2022
ee21eae
feat: initial draft for IO menu
gw2princeps Apr 10, 2022
340e91d
feat: add profession icon to saved results
gw2princeps Apr 10, 2022
e19ff12
styling: backgorund of tables
gw2princeps Apr 10, 2022
920015a
styling: adjust icon size
gw2princeps Apr 10, 2022
aea54c9
fix: add locally saved ones to the front of the existing list
gw2princeps Apr 10, 2022
f96f8e4
feat: more infos shown in saved results manager
gw2princeps Apr 11, 2022
2ac8611
feat: add import
gw2princeps Apr 11, 2022
06f16dd
feat: added infusions to gear hover
gw2princeps Apr 11, 2022
1506f9f
styling: increase profession size
gw2princeps Apr 11, 2022
eb7562d
fix: bunch of react console errors
gw2princeps Apr 11, 2022
b825cc6
feat: allow array imports
gw2princeps Apr 11, 2022
0d8fbaa
styling: delete icon red only on hover
gw2princeps Apr 12, 2022
446ef33
feat: add helper text for result manager
gw2princeps Apr 12, 2022
1fae87c
feat: add helper text to the saved results as well
gw2princeps Apr 16, 2022
07b6ad4
Merge branch 'staging' into feat/character-local-storage
marcustyphoon May 9, 2022
40f848c
Fix: Consistent save/remove button spacing
marcustyphoon May 10, 2022
4d59f98
Fix: lint
marcustyphoon May 10, 2022
4bc1e39
Merge branch 'main' into feat/character-local-storage
marcustyphoon May 29, 2024
cdcd259
Merge branch 'main' into feat/character-local-storage
marcustyphoon May 29, 2024
10bf538
fix: star color
marcustyphoon May 29, 2024
5c35cad
simplify savedcomponent
marcustyphoon May 29, 2024
3174682
cleanup
marcustyphoon May 29, 2024
5bb7e88
disable button when it does nothing
marcustyphoon May 29, 2024
16c6060
tweak UI copy
marcustyphoon May 29, 2024
4271453
refactor checkmark system
marcustyphoon May 30, 2024
813e2aa
fix: text box loses focus when edited
marcustyphoon May 30, 2024
8f49267
fix "refactor checkmark system"
marcustyphoon May 30, 2024
ac79750
use `createObjectURL`
marcustyphoon May 30, 2024
830a69d
prevent importing junk
marcustyphoon May 30, 2024
7ff14d9
prevent saving the same build twice
marcustyphoon May 30, 2024
7d6ba9d
import pasted json to persistent build section
marcustyphoon May 30, 2024
ac50d74
tweak UI copy
marcustyphoon May 30, 2024
8690f4c
tweak UI copy
marcustyphoon May 30, 2024
bbc5ef5
Merge branch 'main' into feat/character-local-storage
marcustyphoon Aug 6, 2024
f1d5b59
Chore: Remove unused catch arguments
marcustyphoon Aug 6, 2024
7015890
Merge branch 'main' into feat/character-local-storage
marcustyphoon Sep 17, 2024
713a817
chore: replace mui system props with sx
marcustyphoon Sep 17, 2024
7311a50
Merge branch 'main' into feat/character-local-storage
marcustyphoon Sep 28, 2024
c3424c5
Merge branch 'main' into feat/character-local-storage
marcustyphoon Sep 30, 2024
82b129e
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 1, 2024
98a84f1
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 3, 2024
7f61e68
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 4, 2024
94c6ea5
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 13, 2024
3572bb6
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 16, 2024
7ef4b6f
Revert "feat: Option to show saved table header"
marcustyphoon Oct 16, 2024
1a6aa38
Merge branch 'temp-no-saved-header' into feat/character-local-storage
marcustyphoon Oct 16, 2024
b34b810
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 18, 2024
4514d51
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 26, 2024
9c8e492
Merge branch 'main' into feat/character-local-storage
marcustyphoon Oct 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"Alternative Critical Chance": "Alternative Critical Chance",
"Alternative Critical Damage": "Alternative Critical Damage",
"Applied Modifers": "Applied Modifers",
"Armor": "Armor",
"Auto-disable ritualist trinkets": "Auto-disable ritualist trinkets",
"Bonuses": "Bonuses",
"Buffs & Boons": "Buffs & Boons",
Expand All @@ -49,6 +50,8 @@
"Copied long link to clipboard! (Link shortener requires cloudflare environment.)": "Copied long link to clipboard! (Link shortener requires cloudflare environment.)",
"Copy Settings to clipboard": "Copy Settings to clipboard",
"Copy build": "Copy build",
"Copy build to temporary saved builds": "Copy build to temporary saved builds",
"Copy data to clipboard": "Copy data to clipboard",
"Copy from selected character": "Copy from selected character",
"Copy selected sigils to both slots": "Copy selected sigils to both slots",
"Create build templates that can be used for the gear optimizer.": "Create build templates that can be used for the gear optimizer.",
Expand All @@ -69,6 +72,7 @@
"Damage Change from ±5 Stat:": "Damage Change from ±5 Stat:",
"Damage Distribution": "Damage Distribution",
"Decline": "Decline",
"Delete": "Delete",
"Delete visible": "Delete visible",
"Desired Affixes": "Desired Affixes",
"Development": "Development",
Expand Down Expand Up @@ -98,12 +102,14 @@
"Formatting examples": "Formatting examples",
"Fractals": "Fractals",
"Game Mode": "Game Mode",
"Gear": "Gear",
"Gear Optimizer": "Gear Optimizer",
"Generate shareable links here!": "Generate shareable links here!",
"Global Settings": "Global Settings",
"Healing": "Healing",
"Help": "Help",
"Highlight differing gear": "Highlight differing gear",
"Import": "Import",
"Include ": "Include ",
"Includes the current options on this page and the currently selected character. Does not include every result in the table.": "Includes the current options on this page and the currently selected character. Does not include every result in the table.",
"Includes the current selected options on this page. Does not include every result in the table.": "Includes the current selected options on this page. Does not include every result in the table.",
Expand Down Expand Up @@ -134,7 +140,9 @@
"Optimize for:": "Optimize for:",
"Optimizer Templates": "Optimizer Templates",
"Outgoing Healing": "Outgoing Healing",
"Paste build data to import": "Paste build data to import",
"Per-Slot Exclusions": "Per-Slot Exclusions",
"Persistent build storage": "Persistent build storage",
"Phantasm Critical Chance": "Phantasm Critical Chance",
"Phantasm Critical Damage": "Phantasm Critical Damage",
"Phantasm Effective Power": "Phantasm Effective Power",
Expand All @@ -154,7 +162,9 @@
"Resume": "Resume",
"Runes": "Runes",
"Runes & Sigils & Food": "Runes & Sigils & Food",
"Save to persistent build storage": "Save to persistent build storage",
"Saved Results": "Saved Results",
"Saved Results Manager": "Saved Results Manager",
"Select 'Dual wield' if you're using weapons in both hands or 'Two-handed' when using a two-handed weapon.": "Select 'Dual wield' if you're using weapons in both hands or 'Two-handed' when using a two-handed weapon.",
"Select Affixes": "Select Affixes",
"Select a build template from the menu above!": "Select a build template from the menu above!",
Expand All @@ -181,7 +191,6 @@
"Show per-slot controls": "Show per-slot controls",
"Show prices": "Show prices",
"Show rarity controls": "Show rarity controls",
"Show saved results table header": "Show saved results table header",
"Sigil 1": "Sigil 1",
"Sigil 2": "Sigil 2",
"Sigils": "Sigils",
Expand All @@ -197,8 +206,11 @@
"Survivability": "Survivability",
"Target AR": "Target AR",
"Target settings": "Target settings",
"Temporary saved builds": "Temporary saved builds",
"The gear optimizer is still being developed! Please report issues or suggest improvements in the Discretize <2>Discord</2> or on <6><0></0> Github</6>.": "The gear optimizer is still being developed! Please report issues or suggest improvements in the Discretize <2>Discord</2> or on <6><0></0> Github</6>.",
"There was an error exporting the state!": "There was an error exporting the state!",
"These builds will be deleted after you leave or refresh this page.": "These builds will be deleted after you leave or refresh this page.",
"These builds will remain saved in your browser's local storage. Clearing your cache or application data will remove your builds.": "These builds will remain saved in your browser's local storage. Clearing your cache or application data will remove your builds.",
"This class does not appear to have skills with extra buffs": "This class does not appear to have skills with extra buffs",
"This data represents your rotation. If we don't supply a template for a build, you can calculate the correct coefficients so that a tested build matches a golem log using the tool under \"development\" below, or calculate them manually.": "This data represents your rotation. If we don't supply a template for a build, you can calculate the correct coefficients so that a tested build matches a golem log using the tool under \"development\" below, or calculate them manually.",
"Threads": "Threads",
Expand All @@ -208,13 +220,15 @@
"Trait Template": "Trait Template",
"Traitline": "Traitline {{ lineNr }}",
"Traits": "Traits",
"Trinkets": "Trinkets",
"Two-handed": "Two-handed",
"Unselect all": "Unselect all",
"Use Owned <1></1>:": "Use Owned <1></1>:",
"Use exotic rarity": "Use exotic rarity",
"Utility": "Utility",
"Warning: Shared character links do not currently support exotic gear.": "Warning: Shared character links do not currently support exotic gear.",
"Weapon type:": "Weapon type:",
"Weapons": "Weapons",
"Website Templates": "Website Templates",
"What to optimize the results for. 'Damage' includes power and condition damage according to the distribution below.": "What to optimize the results for. 'Damage' includes power and condition damage according to the distribution below.",
"Would you like to apply the version of your current template? This will overwrite your current form selections.": "Would you like to apply the version of your current template? This will overwrite your current form selections.",
Expand Down
18 changes: 0 additions & 18 deletions src/components/sections/controls/ResultTableSettings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ import {
changeDisplayAttributes,
changeFilterMode,
changeHighlightDiffering,
changeSavedHeader,
changeTallTable,
getCompareByPercent,
getDisplayAttributes,
getFilterMode,
getHighlightDiffering,
getSavedHeader,
getTallTable,
} from '../../../state/slices/controlsSlice';
import Settings from '../../baseComponents/Settings';
Expand All @@ -53,7 +51,6 @@ export default function ResultTableSettings() {
const highlightDiffering = useSelector(getHighlightDiffering);

const tallTable = useSelector(getTallTable);
const savedHeader = useSelector(getSavedHeader);
const filterMode = useSelector(getFilterMode);
const displayAttributes = useSelector(getDisplayAttributes);

Expand Down Expand Up @@ -93,21 +90,6 @@ export default function ResultTableSettings() {
/>
</Box>

<Box sx={{ mt: 1.5 }}>
<FormControlLabel
control={
<Switch
checked={savedHeader}
onChange={(e) => dispatch(changeSavedHeader(e.target.checked))}
name="checked"
color="primary"
/>
}
label={t('Show saved results table header')}
classes={{ label: classes.comparisonLabel }}
/>
</Box>

<Box sx={{ mt: 1.5 }}>
<FormControlLabel
control={
Expand Down
Loading
Loading