Rename variable skip_team_creation (#38)

Suggested fix for #32

README.md

@@ -148,7 +148,7 @@ repositories = {
     template = "" # optional, default is ""
     topics = []
     visibility = "public" # optional, default is "public"
-    skip_team_creation = optional(bool, false) # Do not create teams for repository
+    is_django_commons_repo = optional(bool, false) # Do not create teams for repository
     enable_branch_protection = true # optional, default is true
     required_status_checks_contexts = [] # optional, default is []
     admins = [] # Members of the repository's admin and repository teams. Have admin permissions

terraform/README.md

@@ -50,7 +50,7 @@ All changes should be made in `production/*.tfvars`:
         template = "" # optional, default is ""
         topics = []
         visibility = "public" # optional, default is "public"
-        skip_team_creation = optional(bool, false) # Do not create teams for repository
+        is_django_commons_repo = optional(bool, false) # Do not create teams for repository
         enable_branch_protection = true # optional, default is true
         required_status_checks_contexts = [] # optional, default is []
         admins = [] # Members of the repository's admin and repository teams. Have admin permissions

terraform/production/repositories.tfvars

@@ -6,9 +6,9 @@ repositories = {
     description              = "A Special Repository."
     enable_branch_protection = false
 
-    topics             = []
-    push_allowances    = []
-    skip_team_creation = true
+    topics                 = []
+    push_allowances        = []
+    is_django_commons_repo = true
   }
 
   "controls" = {
@@ -19,18 +19,18 @@ repositories = {
     allow_squash_merge       = true
     topics                   = []
     push_allowances          = []
-    skip_team_creation       = true
+    is_django_commons_repo   = true
   }
 
   "membership" = {
-    description        = "Membership repository for the django-commons organization."
-    visibility         = "public"
-    allow_merge_commit = true
-    allow_rebase_merge = true
-    allow_squash_merge = true
-    topics             = []
-    push_allowances    = []
-    skip_team_creation = true
+    description            = "Membership repository for the django-commons organization."
+    visibility             = "public"
+    allow_merge_commit     = true
+    allow_rebase_merge     = true
+    allow_squash_merge     = true
+    topics                 = []
+    push_allowances        = []
+    is_django_commons_repo = true
   }
 
   "django-commons-playground" = {

terraform/resources-repo-admin-teams.tf

@@ -1,6 +1,6 @@
 # Define the admin team for each repository
 resource "github_team" "repo_admin_team" {
-  for_each = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
 
   parent_team_id = github_team.repo_team[each.key].id
   name           = "${each.key}-admins"
@@ -10,7 +10,7 @@ resource "github_team" "repo_admin_team" {
 
 # Add the people to the team
 resource "github_team_members" "repo_admin_members" {
-  for_each = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
 
   team_id = github_team.repo_admin_team[each.key].id
 
@@ -26,7 +26,7 @@ resource "github_team_members" "repo_admin_members" {
 
 # Define the team's permissions for the repositories
 resource "github_team_repository" "repo_admin_team_access" {
-  for_each   = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each   = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
   repository = each.key
   team_id    = github_team.repo_admin_team[each.key].id
   permission = "admin"

terraform/resources-repo-committer-teams.tf

@@ -1,6 +1,6 @@
 # Define the committers team for each repository
 resource "github_team" "repo_committer_team" {
-  for_each = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
 
   parent_team_id = github_team.repo_team[each.key].id
   name           = "${each.key}-committers"
@@ -12,7 +12,7 @@ resource "github_team" "repo_committer_team" {
 resource "github_team_members" "repo_committer_team_members" {
   for_each = {
     for k, v in var.repositories : k => v
-    if v.skip_team_creation == false && length(v.committers) > 0
+    if v.is_django_commons_repo == false && length(v.committers) > 0
   }
 
   team_id = github_team.repo_committer_team[each.key].id
@@ -31,7 +31,7 @@ resource "github_team_members" "repo_committer_team_members" {
 resource "github_team_repository" "repo_committer_team_access" {
   for_each = {
     for k, v in var.repositories : k => v
-    if v.skip_team_creation == false
+    if v.is_django_commons_repo == false
   }
   repository = each.key
   team_id    = github_team.repo_committer_team[each.key].id

terraform/resources-repo-teams.tf

@@ -1,14 +1,14 @@
 # Create the main repository team for Django Commons.
 resource "github_team" "repo_team" {
-  for_each = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
 
   name        = each.key
   description = "Main team for the ${each.key} repository"
   privacy     = "closed"
 }
 # Add the people to the team
 resource "github_team_members" "repo_team_members" {
-  for_each = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
 
   team_id = github_team.repo_team[each.key].id
 
@@ -27,7 +27,7 @@ resource "github_team_members" "repo_team_members" {
 }
 # Define the team's permissions for the repositories
 resource "github_team_repository" "repo_team_access" {
-  for_each   = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each   = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
   repository = each.key
   team_id    = github_team.repo_team[each.key].id
   permission = "triage"
@@ -37,7 +37,7 @@ resource "github_team_repository" "repo_team_access" {
 
 # This is used to enable automatic PR review requests
 resource "github_team_settings" "this" {
-  for_each = { for k, v in var.repositories : k => v if v.skip_team_creation == false }
+  for_each = { for k, v in var.repositories : k => v if v.is_django_commons_repo == false }
 
   review_request_delegation {
     algorithm    = "LOAD_BALANCE"

terraform/variables.tf

@@ -39,7 +39,7 @@ variable "repositories" {
     template                        = optional(string)
     topics                          = optional(list(string))
     visibility                      = optional(string, "public")
-    skip_team_creation              = optional(bool, false)     # Do not create teams for repository
+    is_django_commons_repo          = optional(bool, false)     # Do not create teams for repository
     admins                          = optional(set(string), []) # Members of the repository's admin and repository teams. Have admin permissions
     committers                      = optional(set(string), [])
     # Members of the repository's committers and repository teams. Have write permissions