Upgrade to PHPUnit 10 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Feb 18, 2024
| @@ -20,7 +20,7 @@ | |||
| use function next; | |||
| use function reset; | |||
|
|
|||
| abstract class BaseArrayCollectionTest extends TestCase | |||
| abstract class BaseArrayCollectionTestCase extends TestCase | |||
There was a problem hiding this comment.
Suggested change
| abstract class BaseArrayCollectionTestCase extends TestCase | |
| abstract class ArrayCollectionTestCase extends TestCase |
The Base prefix feels redundant now.
derrabus
reviewed
Feb 19, 2024
Comment on lines
23
to
29
| ['type' => CompositeExpression::TYPE_NOT, 'expressions' => [$this->createMock(Expression::class), $this->createMock(Expression::class)]], | ||
| [ | ||
| 'type' => CompositeExpression::TYPE_NOT, | ||
| 'expressions' => [ | ||
| new class () implements Expression { | ||
| public function visit(ExpressionVisitor $visitor) | ||
| { | ||
| } | ||
| }, | ||
| new class () implements Expression { | ||
| public function visit(ExpressionVisitor $visitor) | ||
| { | ||
| } | ||
| }, | ||
| ], | ||
| ], |
There was a problem hiding this comment.
You could use self::createStub() to replace $this->createMock() in a static method.
There was a problem hiding this comment.
TIL createMock is not statick, but createStub is 💡
derrabus
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.