Skip to content

Conversation

@raultorrecilla
Copy link

@raultorrecilla raultorrecilla commented Jul 25, 2025

I could not download the images in Mac so I ended up changing this to make it work

Closes #868

I could not download the images so I ended up doing this to pull them
Copilot AI review requested due to automatic review settings July 25, 2025 13:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates container image configurations in the AppHost to use more compatible versions that work on Mac systems. The changes replace specific image versions with either latest tags or more compatible image sources.

  • Updates Redis configuration to use the official Redis image with latest tag
  • Changes RabbitMQ to use latest tag instead of a specific version
  • Replaces the pgvector image source from ankane/pgvector to pgvector/pgvector with a specific version

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +14 to +15
.WithImage("pgvector/pgvector")
.WithImageTag("0.8.0-pg17")
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PostgreSQL image has been updated from ankane/pgvector to pgvector/pgvector with tag 0.8.0-pg17, but the test file tests/Catalog.FunctionalTests/CatalogApiFixture.cs still uses the old ankane/pgvector:latest image. This inconsistency could cause tests to fail or behave differently from the main application. Please update the test fixture to use the same image configuration.

Copilot uses AI. Check for mistakes.
Comment on lines +9 to +11
.WithImageTag("latest");
var rabbitMq = builder.AddRabbitMQ("eventbus")
.WithImageTag("latest")
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using the "latest" tag for container images can lead to unpredictable behavior and difficult-to-reproduce issues, as the "latest" tag may point to different versions over time. Consider pinning to a specific version tag (e.g., "7.4" or "7.4.2") for Redis to ensure consistency across environments. The same applies to RabbitMQ on line 11.

Suggested change
.WithImageTag("latest");
var rabbitMq = builder.AddRabbitMQ("eventbus")
.WithImageTag("latest")
.WithImageTag("7.2.4");
var rabbitMq = builder.AddRabbitMQ("eventbus")
.WithImageTag("3.12.12-management")

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eShop on Mac + VS Code fails to pull redis, postgre and eventbus images

1 participant