-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update Program.cs to latest official images that work on Mac #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I could not download the images so I ended up doing this to pull them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates container image configurations in the AppHost to use more compatible versions that work on Mac systems. The changes replace specific image versions with either latest tags or more compatible image sources.
- Updates Redis configuration to use the official Redis image with latest tag
- Changes RabbitMQ to use latest tag instead of a specific version
- Replaces the pgvector image source from ankane/pgvector to pgvector/pgvector with a specific version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .WithImage("pgvector/pgvector") | ||
| .WithImageTag("0.8.0-pg17") |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PostgreSQL image has been updated from ankane/pgvector to pgvector/pgvector with tag 0.8.0-pg17, but the test file tests/Catalog.FunctionalTests/CatalogApiFixture.cs still uses the old ankane/pgvector:latest image. This inconsistency could cause tests to fail or behave differently from the main application. Please update the test fixture to use the same image configuration.
| .WithImageTag("latest"); | ||
| var rabbitMq = builder.AddRabbitMQ("eventbus") | ||
| .WithImageTag("latest") |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using the "latest" tag for container images can lead to unpredictable behavior and difficult-to-reproduce issues, as the "latest" tag may point to different versions over time. Consider pinning to a specific version tag (e.g., "7.4" or "7.4.2") for Redis to ensure consistency across environments. The same applies to RabbitMQ on line 11.
| .WithImageTag("latest"); | |
| var rabbitMq = builder.AddRabbitMQ("eventbus") | |
| .WithImageTag("latest") | |
| .WithImageTag("7.2.4"); | |
| var rabbitMq = builder.AddRabbitMQ("eventbus") | |
| .WithImageTag("3.12.12-management") |
I could not download the images in Mac so I ended up changing this to make it work
Closes #868