Skip to content

Update Program.cs to latest official images that work on Mac #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raultorrecilla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Program.cs to latest official images that work on Mac #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/eShop.AppHost/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@

builder.AddForwardedHeaders();

var redis = builder.AddRedis("redis");
var redis = builder.AddRedis("redis")
.WithImage("redis")
.WithImageTag("latest");
var rabbitMq = builder.AddRabbitMQ("eventbus")
.WithImageTag("latest")
Comment on lines +9 to +11
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using the "latest" tag for container images can lead to unpredictable behavior and difficult-to-reproduce issues, as the "latest" tag may point to different versions over time. Consider pinning to a specific version tag (e.g., "7.4" or "7.4.2") for Redis to ensure consistency across environments. The same applies to RabbitMQ on line 11.

Suggested change
.WithImageTag("latest");
var rabbitMq = builder.AddRabbitMQ("eventbus")
.WithImageTag("latest")
.WithImageTag("7.2.4");
var rabbitMq = builder.AddRabbitMQ("eventbus")
.WithImageTag("3.12.12-management")

Copilot uses AI. Check for mistakes.
.WithLifetime(ContainerLifetime.Persistent);
var postgres = builder.AddPostgres("postgres")
.WithImage("ankane/pgvector")
.WithImageTag("latest")
.WithImage("pgvector/pgvector")
.WithImageTag("0.8.0-pg17")
Comment on lines +14 to +15
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PostgreSQL image has been updated from ankane/pgvector to pgvector/pgvector with tag 0.8.0-pg17, but the test file tests/Catalog.FunctionalTests/CatalogApiFixture.cs still uses the old ankane/pgvector:latest image. This inconsistency could cause tests to fail or behave differently from the main application. Please update the test fixture to use the same image configuration.

Copilot uses AI. Check for mistakes.
.WithLifetime(ContainerLifetime.Persistent);

var catalogDb = postgres.AddDatabase("catalogdb");
Expand Down