add .editorconfig file #2138
add .editorconfig file #2138
Conversation
.editorconfig
Outdated
| insert_final_newline = true | ||
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false |
There was a problem hiding this comment.
looks like this file is lacking the insert_final_newline? 😀
There was a problem hiding this comment.
Yes, python files usually have 4 spaces. I have fixed it and add the final newline style for the .md file. Thanks.
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false | ||
| insert_final_newline = false |
There was a problem hiding this comment.
Why are these both false for markdown? Why not make them true (or more concisely, simply drop the markdown specific section since it is identical to the global config)
There was a problem hiding this comment.
These are only common writing formats for some special files. I think it is fine not to add blank line or remove any whitespace characters preceding newline characters in Markdown file. You can set what you want. Just keep all the files consistent. Thanks.
|
Thanks for updating! Can you clarify why the markdown section has these configs? The other stuff looks good... |
Fix #2125
This file is used to keep all the files consistent. It is convenient for other people to contribute to the same project.
This change is