Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .editorconfig file #2138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add .editorconfig file #2138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e722341
add .editorconfig
lixiaoqity Oct 10, 2020
2ed7432
modify edit style
lixiaoqity Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# http://editorconfig.org
root = true

[*]
indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.py]
indent_size = 4

[*.md]
trim_trailing_whitespace = false
insert_final_newline = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these both false for markdown? Why not make them true (or more concisely, simply drop the markdown specific section since it is identical to the global config)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only common writing formats for some special files. I think it is fine not to add blank line or remove any whitespace characters preceding newline characters in Markdown file. You can set what you want. Just keep all the files consistent. Thanks.