Skip to content

Conversation

@gaius-qi
Copy link
Member

Description

This pull request adds tracing instrumentation to key methods in both the ParentSelector and PersistentCacheParentSelector implementations in dragonfly-client/src/resource/parent_selector.rs. The primary goal is to improve observability and debugging by enabling detailed tracing of method calls without logging their arguments.

Instrumentation for observability:

  • Added the #[instrument(skip_all)] attribute to the following methods in ParentSelector:

    • select
    • register
    • unregister
    • get_idle_tx_bandwidth
  • Added the #[instrument(skip_all)] attribute to the following methods in PersistentCacheParentSelector:

    • select
    • register
    • unregister
    • get_idle_tx_bandwidth

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.4.0 milestone Nov 21, 2025
@gaius-qi gaius-qi self-assigned this Nov 21, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.03%. Comparing base (504b7de) to head (97d8bc1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   47.53%   48.03%   +0.49%     
==========================================
  Files          70       70              
  Lines       17724    17540     -184     
==========================================
  Hits         8425     8425              
+ Misses       9299     9115     -184     
Files with missing lines Coverage Δ
dragonfly-client/src/resource/parent_selector.rs 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi enabled auto-merge (squash) November 24, 2025 02:25
@gaius-qi gaius-qi disabled auto-merge November 25, 2025 02:36
@gaius-qi gaius-qi merged commit 10d381e into main Nov 25, 2025
9 checks passed
@gaius-qi gaius-qi deleted the feature/span branch November 25, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants