Skip to content

refactor(resource): add tracing to parent selector methods #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

refactor(resource): add tracing to parent selector methods #1482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dragonfly-client/src/resource/parent_selector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ impl ParentSelector {
/// This function performs weighted random selection where parents with higher weights
/// (better idle bandwidth) have a higher probability of being selected. If weight
/// calculation fails, falls back to uniform random selection.
#[instrument(skip_all)]
pub fn select(&self, parents: Vec<CollectedParent>) -> CollectedParent {
let weights: Vec<u32> = parents
.iter()
Expand Down Expand Up @@ -195,6 +196,7 @@ impl ParentSelector {
/// - Creates a new gRPC connection if one doesn't exist.
/// - Spawns a background task to continuously sync host metrics (bandwidth, load).
/// - Updates the connection's request counter.
#[instrument(skip_all)]
pub async fn register(&self, parents: &[Peer]) -> Result<()> {
let dfdaemon_shutdown = self.shutdown.clone();
let mut join_set = JoinSet::new();
Expand Down Expand Up @@ -265,6 +267,7 @@ impl ParentSelector {
/// - Triggers connection shutdown.
/// - Removes the weight entry.
/// - Removes the connection from the pool.
#[instrument(skip_all)]
pub fn unregister(&self, parents: &[Peer]) {
for parent in parents {
info!("unregister parent {}", parent.id);
Expand Down Expand Up @@ -352,6 +355,7 @@ impl ParentSelector {
}

/// Calculates the idle transmission bandwidth of a host.
#[instrument(skip_all)]
fn get_idle_tx_bandwidth(host: &Host) -> u64 {
let network = match &host.network {
Some(network) => network,
Expand Down Expand Up @@ -443,6 +447,7 @@ impl PersistentCacheParentSelector {
/// This function performs weighted random selection where parents with higher weights
/// (better idle bandwidth) have a higher probability of being selected. If weight
/// calculation fails, falls back to uniform random selection.
#[instrument(skip_all)]
pub fn select(&self, parents: Vec<CollectedParent>) -> CollectedParent {
let weights: Vec<u32> = parents
.iter()
Expand Down Expand Up @@ -490,6 +495,7 @@ impl PersistentCacheParentSelector {
/// - Creates a new gRPC connection if one doesn't exist.
/// - Spawns a background task to continuously sync host metrics (bandwidth, load).
/// - Updates the connection's request counter.
#[instrument(skip_all)]
pub async fn register(&self, parents: &[PersistentCachePeer]) -> Result<()> {
let dfdaemon_shutdown = self.shutdown.clone();
let mut join_set = JoinSet::new();
Expand Down Expand Up @@ -563,6 +569,7 @@ impl PersistentCacheParentSelector {
/// - Triggers connection shutdown.
/// - Removes the weight entry.
/// - Removes the connection from the pool.
#[instrument(skip_all)]
pub fn unregister(&self, parents: &[PersistentCachePeer]) {
for parent in parents {
info!("unregister persistent cache parent {}", parent.id);
Expand Down Expand Up @@ -656,6 +663,7 @@ impl PersistentCacheParentSelector {
}

/// Calculates the idle transmission bandwidth of a host.
#[instrument(skip_all)]
fn get_idle_tx_bandwidth(host: &Host) -> u64 {
let network = match &host.network {
Some(network) => network,
Expand Down