Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits Fn and Shift on {0, ..., 9, -, =} for QWERTY #1

Open
wants to merge 1 commit into
base: bookworm
Choose a base branch
from

Conversation

nsensfel
Copy link

This commit is intended to provide access to the F1-F12 keys on the F(x)tec Pro1. I have not tested it.
When using the phone with a userland meant for Linux (either directly on the phone, or through remote control), it is common to find applications that expect F1-F12 keys to be available. This commit would turn the redundant Fn+{1, ..., 9, 0, -, =} combination, which were hitherto aliased to Shift+{1, ..., 9, 0, -, =}, into {F1, ..., F12} when using the QWERTY layout. Such a change would be more complicated to bring on the QWERTZ layout, as some of these combinations are already meaningful in that configuration, so it remains untouched.

I have chosen the {F1, ..., F12} keys because those are what I would like to map these combinations to, but I think ultimately the choice ought to be made by the user (and thus, in userspace). To my understanding, this cannot be done as long as the driver itself makes the aliasing. Of course, I would be remiss not to mention the best argument in favor of this change: as it stands, the F(x)tec phone does not have the F(x) tech. 😜

This commit is intended to provide access to the F1-F12 keys on the F(x)tec Pro1.
I have not tested it.
When using the phone with a userland meant for Linux (either directly on the phone, or through remote control), it is common to find applications that expect F1-F12 keys to be available.
This commit would turn the redundant Fn+{1, ..., 9, 0, -, =} combination, which were hitherto aliased to Shift+{1, ..., 9, 0, -, =}, into {F1, ..., F12} when using the QWERTY layout.
Such a change would be more complicated to bring on the QWERTZ layout, as some of these combinations are already meaningful in that configuration, so it remains untouched.

I have chosen the {F1, ..., F12} keys because those are what I would like to map these combinations to, but I think ultimately the choice ought to be made by the user (and thus, in userspace). To my understanding, this cannot be done as long as the driver itself makes the aliasing. Of course, I would be remiss not to mention the best argument in favor of this change: as it stands, the F(x)tec phone does not have the F(x) tech. 😜
@g7
Copy link
Member

g7 commented Oct 15, 2022

Hey, thank you for your contribution!

I think that these changes make sense (and I agree that this should all be handled in userspace, but oh well), but unfortunately it will deviate from what's actually printed on the keycaps, so I'm not really comfortable in doing this by default.

What would be a good compromise is to perhaps add in the driver support for an alternate layout so that it can be explicitly be chosen by the user (like it happens for the QWERTZ layout). This will probably also help droidian/droidian#7 which is somewhat related.

What do you think? Paging @Kabouik as well as he's the author of that referenced feature request.

@Kabouik
Copy link

Kabouik commented Apr 25, 2023

I am sorry I totally missed the notification. I have no say here, but if I were to vote, I'd be all for allowing such changes in userspace too, as I understand deviating from keyprints would be confusing to new users even if that could improve the overall experience.

The things in #7 (and the F1-F12 keys are a very relevant addition) are a major limitation for me to use the Pro1(x) as a UMPC as I used to with my SFOS unit (I still daily-drive a SFOS unit (and carry a Droidian unit in the other pocket!), but it is a Pro1x which uses the Droidian kernel, so the limitations discussed here apply). However, I have no idea what would be required to make it possible in userland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants