Omnibar Refactor: NewOmnibar #5129
Open
+3,491
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
malmstein
force-pushed
the
feature/david/09-27-omnibar_refactor_newomnibar
branch
from
dc5cc72
to
abfeda3
Compare
0nko
reviewed
Oct 14, 2024
| @@ -3648,7 +3731,7 @@ class BrowserTabFragment : | |||
| omnibar.renderOmnibarViewState(viewState) | |||
|
|
|||
| lastSeenBrowserViewState?.let { | |||
| omnibar.renderBrowserViewState(it, tabDisplayedInCustomTabScreen) | |||
| // omnibar.renderBrowserViewState(it, tabDisplayedInCustomTabScreen) | |||
There was a problem hiding this comment.
it should be deleted, this is not necessary and it’s redundant. for all and new omnibars.
malmstein
force-pushed
the
feature/david/09-27-omnibar_refactor_newomnibar
branch
from
75ef894
to
3f5563e
Compare
0nko
reviewed
Oct 14, 2024
app/src/main/java/com/duckduckgo/app/browser/omnibar/Omnibar.kt
Outdated
Show resolved
Hide resolved
0nko
reviewed
Oct 14, 2024
app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayout.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208319036523675/f
Description
This PR adds a feature flag to switch between the new
OmnibarLayoutand the oldLegacyOmnibarViewSteps to test this PR
See https://app.asana.com/0/1174433894299346/1208529636754079/f