Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omnibar Refactor: NewOmnibar #5129

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

Omnibar Refactor: NewOmnibar #5129

wants to merge 44 commits into from

Commits on Oct 14, 2024

  1. Omnibar Refactor: NewOmnibar

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9901c78 View commit details
    Browse the repository at this point in the history

  2. adding bottom support for newomnibar

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bb4b116 View commit details
    Browse the repository at this point in the history

  3. proper scope for newomnibar

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a50714e View commit details
    Browse the repository at this point in the history

  4. more cleanup

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    516774b View commit details
    Browse the repository at this point in the history

  5. bridging between old and new opmnibar based on toggle

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    42ac8f1 View commit details
    Browse the repository at this point in the history

  6. showing legacy or new omnibar depending on feature flag

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8cef529 View commit details
    Browse the repository at this point in the history

  7. add support for custom tabs

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f93845f View commit details
    Browse the repository at this point in the history

  8. missing references to new omnibar

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f427959 View commit details
    Browse the repository at this point in the history

  9. keep moving

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    88f23f1 View commit details
    Browse the repository at this point in the history

  10. keep moving listeners to a better place

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    35535c3 View commit details
    Browse the repository at this point in the history

  11. moving to own listeners in omnibar layout

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e8187a2 View commit details
    Browse the repository at this point in the history

  12. ensure omnibar text is properly updated

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6e38ae8 View commit details
    Browse the repository at this point in the history

  13. added missing pixels

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3809472 View commit details
    Browse the repository at this point in the history

  14. remove unnecessary commands

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b8ab2c6 View commit details
    Browse the repository at this point in the history

  15. enable support for chrome custom tabs

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8bfe654 View commit details
    Browse the repository at this point in the history

  16. add support for custom tab title change

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b0ed2b1 View commit details
    Browse the repository at this point in the history

  17. enable item highlighting

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3e49c4f View commit details
    Browse the repository at this point in the history

  18. no need to update if not highlighted

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b08b2b0 View commit details
    Browse the repository at this point in the history

  19. custom tab title should not be duplicated

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3503d41 View commit details
    Browse the repository at this point in the history

  20. working on tabs

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ef76280 View commit details
    Browse the repository at this point in the history

  21. trying to get the tabs properly

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    abb7c70 View commit details
    Browse the repository at this point in the history

  22. added onAttached tests

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cd37aa5 View commit details
    Browse the repository at this point in the history

  23. added onAttached tests

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0e48cb1 View commit details
    Browse the repository at this point in the history

  24. remove old view

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f11fd33 View commit details
    Browse the repository at this point in the history

  25. added more omnibar focus tests

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0a1890f View commit details
    Browse the repository at this point in the history

  26. ensure omnibar changes position

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2d5b260 View commit details
    Browse the repository at this point in the history

  27. added viewmode tests

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c61b337 View commit details
    Browse the repository at this point in the history

  28. added all missing tests for omnibarviewmodel

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bb59884 View commit details
    Browse the repository at this point in the history

  29. fix loading icon tests

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    14039bd View commit details
    Browse the repository at this point in the history

  30. ensure viewstate is properly updated

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8f89934 View commit details
    Browse the repository at this point in the history

  31. rollback privacy config service

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    aad3c98 View commit details
    Browse the repository at this point in the history

  32. ensure leading icon is search when omnibar focused

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    535dde7 View commit details
    Browse the repository at this point in the history

  33. don't play trackers animation if no trackers are blocked

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3316a90 View commit details
    Browse the repository at this point in the history

  34. ensure omnibar is shown when links tapped

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2216476 View commit details
    Browse the repository at this point in the history

  35. fix test reference

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7439df5 View commit details
    Browse the repository at this point in the history

  36. fix scrolling behaviour

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2b20f6c View commit details
    Browse the repository at this point in the history

  37. added tests for scrolling behaviour

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3f5563e View commit details
    Browse the repository at this point in the history

  38. fix reference

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e0f2ff5 View commit details
    Browse the repository at this point in the history

  39. Fix the new omnibar scrolling

    @0nko
    0nko committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2eb4fa9 View commit details
    Browse the repository at this point in the history

  40. Remove redundant code

    @0nko
    0nko committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4167823 View commit details
    Browse the repository at this point in the history

  41. Use the ViewModel as a source of truth

    @0nko
    0nko committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9103085 View commit details
    Browse the repository at this point in the history

  42. tabs should only update if tab number is different

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3d52c59 View commit details
    Browse the repository at this point in the history

  43. remove unnecessay state update

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7dba40a View commit details
    Browse the repository at this point in the history

  44. fix test for position feature

    @malmstein
    malmstein committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    37ac0d9 View commit details
    Browse the repository at this point in the history