🚑 Patch for showstopping ios popup issue #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2023 12:33
in order to fix the bug, we're changing when we mark the consent in storage. Moving the call to after the user has agreed to both parts -- protocol AND permissions, prevents the early popup. For more discussion see: e-mission/e-mission-docs#1006 (comment)
Abby-Wheelis
changed the base branch from
master
to
onboarding_routing_sept_2023
|
I have implemented (I think) the changes Jack was talking about in this comment. I have confirmed that this patch works by uninstalling the devapp and going through onboarding. The popup only comes up when I click fix, as expected, and looking at log statements confirm that we're stepping through the stages as expected. |
|
I just went back through to check, and I am confident that it does resolve the issue. I'm attaching a video that shows the popup waiting until the appropriate time to launch, and also resolving the "not refreshing" issue, as the check does turn green as soon as the permission is fixed. smallestFixedPopup.movAlso including the log statements here, you can see how the different held states vary, and how consent is marked at the same time as login. 
|
Merged
shankari
merged commit e68b4a8
into
e-mission:onboarding_routing_sept_2023
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that some ordering of processes in onboarding is what was causing #1006, and are fixing it by altering the ordering back to the original. See more discussion on the issue.