Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚑 Patch for showstopping ios popup issue #1071

Merged
merged 2 commits into from
Oct 19, 2023
Merged

🚑 Patch for showstopping ios popup issue #1071

merged 2 commits into from
Oct 19, 2023

Commits on Oct 18, 2023

  1. renameConsentPage to protocolPage

    Abby Wheelis committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    bbb0f68 View commit details
    Browse the repository at this point in the history

  2. alter timing of markConsented 

    in order to fix the bug, we're changing when we mark the consent in storage. Moving the call to after the user has agreed to both parts -- protocol AND permissions, prevents the early popup.

For more discussion see: e-mission/e-mission-docs#1006 (comment)
    Abby Wheelis committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    18f384f View commit details
    Browse the repository at this point in the history