Rewrite + test storedevicesettings.js #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 23, 2023 14:21
after converting to typescript, we switch from an angular service to exported functions to handle the events, switching to exported functions called when that event is accomplished was imported to controller, but never used
|
I knew there would be merge conflicts, so I merged my #1072 branch into this one, that PR should be merged before this one. |
added 6 commits
October 23, 2023 15:27
when I merged my startprefs branch, I forgot to update storedevicesettings to reflect the removal of that angular service
since there is no angular code in this file, can't use $ionicPlatform instead call the init function from the App code
while testing, there were some new or updated mocks needed, as well as some updates to the file in order to allow the tests to wait for these methods to run before testing for the results I don't think we need to await the functions as they're used, however, because it's ok if they run asyncronously in context
…rite-storedevicesettings
|
closing this as the changes are now included in #1093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splash service is very similar to the
startprefsthat I have worked on most recently, it does not seem to be used in any other files, but I think that the device settings it stores are held in the user profile whenupdateUserfromcommHelperis called. So unless I discover that these settings are never retrieved, I think that the service does need to be re-written.