Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite + test storedevicesettings.js #1079

Commits on Oct 23, 2023

  1. start rewrite by renaming the file

    Abby Wheelis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    9a45bf4 View commit details
    Browse the repository at this point in the history
  2. update code, remove references

    after converting to typescript, we switch from an angular service to exported functions
    
    to handle the events, switching to exported functions called when that event is accomplished
    
    was imported to controller, but never used
    Abby Wheelis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ce02579 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa779f6 View commit details
    Browse the repository at this point in the history
  4. resolve merge issue

    when I merged my startprefs branch, I forgot to update storedevicesettings to reflect the removal of that angular service
    Abby Wheelis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    4c0aeb5 View commit details
    Browse the repository at this point in the history
  5. change "ready" handling

    since there is no angular code in this file, can't use $ionicPlatform
    
    instead call the init function from the App code
    Abby Wheelis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    589eca9 View commit details
    Browse the repository at this point in the history
  6. updated file name

    Abby Wheelis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    59ca64d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. implement tests for storedevicesettings

    while testing, there were some new or updated mocks needed, as well as some updates to the file in order to allow the tests to wait for these methods to run before testing for the results
    
    I don't think we need to await the functions as they're used, however, because it's ok if they run asyncronously in context
    Abby Wheelis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    78b5336 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge remote-tracking branch 'upstream/service_rewrite_2023' into rew…

    …rite-storedevicesettings
    Abby Wheelis committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2022e77 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. merge upstream and resolve conflicts

    Abby Wheelis committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f153e2c View commit details
    Browse the repository at this point in the history