-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite + test storedevicesettings.js #1079
Rewrite + test storedevicesettings.js #1079
Commits on Oct 23, 2023
-
start rewrite by renaming the file
Abby Wheelis committedOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 9a45bf4 - Browse repository at this point
Copy the full SHA 9a45bf4View commit details -
update code, remove references
after converting to typescript, we switch from an angular service to exported functions to handle the events, switching to exported functions called when that event is accomplished was imported to controller, but never used
Abby Wheelis committedOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for ce02579 - Browse repository at this point
Copy the full SHA ce02579View commit details -
Merge branch 'startprefs-rewrite' into rewrite-storedevicesettings
Abby Wheelis committedOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for aa779f6 - Browse repository at this point
Copy the full SHA aa779f6View commit details -
when I merged my startprefs branch, I forgot to update storedevicesettings to reflect the removal of that angular service
Abby Wheelis committedOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 4c0aeb5 - Browse repository at this point
Copy the full SHA 4c0aeb5View commit details -
since there is no angular code in this file, can't use $ionicPlatform instead call the init function from the App code
Abby Wheelis committedOct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 589eca9 - Browse repository at this point
Copy the full SHA 589eca9View commit details -
Abby Wheelis committed
Oct 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 59ca64d - Browse repository at this point
Copy the full SHA 59ca64dView commit details
Commits on Oct 24, 2023
-
implement tests for storedevicesettings
while testing, there were some new or updated mocks needed, as well as some updates to the file in order to allow the tests to wait for these methods to run before testing for the results I don't think we need to await the functions as they're used, however, because it's ok if they run asyncronously in context
Abby Wheelis committedOct 24, 2023 Configuration menu - View commit details
-
Copy full SHA for 78b5336 - Browse repository at this point
Copy the full SHA 78b5336View commit details
Commits on Oct 30, 2023
-
Merge remote-tracking branch 'upstream/service_rewrite_2023' into rew…
…rite-storedevicesettings
Abby Wheelis committedOct 30, 2023 Configuration menu - View commit details
-
Copy full SHA for 2022e77 - Browse repository at this point
Copy the full SHA 2022e77View commit details
Commits on Nov 2, 2023
-
merge upstream and resolve conflicts
Abby Wheelis committedNov 2, 2023 Configuration menu - View commit details
-
Copy full SHA for f153e2c - Browse repository at this point
Copy the full SHA f153e2cView commit details