Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved raw_data_use backwards compat hack #1133

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

sebastianbarry
Copy link
Contributor

Moved backwards compat hack to fill in the raw_data_use for programs that don't have it to PrivacyPolicy.tsx, from ProfileSettings.tsx so that the privacy policy is updated for the login screen, and it carries over to the Profile settings screen.

@Abby-Wheelis pointed out with the washingtoncommons program that their privacy policy had a textual error: And @Abby-Wheelis phone on nrel-commute had this textual error:
MicrosoftTeams-image MicrosoftTeams-image (1)

They were both a result of a config not having the raw_data_use field filled in.

We had a backwards compat hack for programs without raw_data_use, but it was only in ProfileSettings.tsx, so now I removed it from there and placed it in PrivacyPolicy.tsx so that it checks for raw_data_use and gets filled in anytime the PrivacyPolicy is rendered.

Also, to fix the double "to to," I just removed the "to" and "para [ES]" from the backwards compat hack.

Moved backwards compat hack to fill in the raw_data_use for programs that don't have it to PrivacyPolicy.tsx, from ProfileSettings.tsx so that the privacy policy is updated for the login screen, and it carries over to the Profile settings screen.
@sebastianbarry
Copy link
Contributor Author

sebastianbarry commented Feb 29, 2024

Testing:

Simulator Screenshot - iPhone 13 - 2024-02-29 at 11 30 46 Simulator Screenshot - iPhone 13 - 2024-02-29 at 10 45 06

@sebastianbarry
Copy link
Contributor Author

sebastianbarry commented Feb 29, 2024

Also, the template survey for creating new configs does not have a raw_data_use field, should I add this?

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.37%. Comparing base (034bee2) to head (0848131).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1133   +/-   ##
=======================================
  Coverage   78.37%   78.37%           
=======================================
  Files          28       28           
  Lines        1702     1702           
  Branches      366      366           
=======================================
  Hits         1334     1334           
  Misses        368      368           
Flag Coverage Δ
unit 78.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Abby-Wheelis
Copy link
Member

pointed out with the washingtoncommons program that their privacy policy had a textual error:

Those screenshots are actually both from my phone on the nrel-commute configuration, but it was washingtoncommons that brought it to my attention because they wanted a few other changes to the intro and noted that this section of the policy was weird!

It also looks like in testing that the privacy policy in the intro and in the developer zone still have different text, with the default reason only being filled in the developer zone, is it possible to have it match in both places?

@sebastianbarry
Copy link
Contributor Author

@Abby-Wheelis My bad, I posted the wrong screenshot. I edited the comment to reflect the proper testing

@shankari
Copy link
Contributor

shankari commented Mar 4, 2024

Also, the template survey for creating new configs does not have a raw_data_use field, should I add this?

Yes, please do.

Also, I don't want to hold this up given that it is fixing something that is currently broken, but can we add some tests for the privacy policy formatting?

@shankari shankari merged commit 3fbc6b5 into e-mission:master Mar 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants