-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved raw_data_use backwards compat hack #1133
Conversation
Moved backwards compat hack to fill in the raw_data_use for programs that don't have it to PrivacyPolicy.tsx, from ProfileSettings.tsx so that the privacy policy is updated for the login screen, and it carries over to the Profile settings screen.
Also, the template survey for creating new configs does not have a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1133 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 28 28
Lines 1702 1702
Branches 366 366
=======================================
Hits 1334 1334
Misses 368 368
Flags with carried forward coverage won't be shown. Click here to find out more. |
Those screenshots are actually both from my phone on the It also looks like in testing that the privacy policy in the intro and in the developer zone still have different text, with the default reason only being filled in the developer zone, is it possible to have it match in both places? |
@Abby-Wheelis My bad, I posted the wrong screenshot. I edited the comment to reflect the proper testing |
Yes, please do. Also, I don't want to hold this up given that it is fixing something that is currently broken, but can we add some tests for the privacy policy formatting? |
Moved backwards compat hack to fill in the raw_data_use for programs that don't have it to PrivacyPolicy.tsx, from ProfileSettings.tsx so that the privacy policy is updated for the login screen, and it carries over to the Profile settings screen.
washingtoncommons
program that their privacy policy had a textual error:nrel-commute
had this textual error:They were both a result of a config not having the
raw_data_use
field filled in.We had a backwards compat hack for programs without
raw_data_use
, but it was only inProfileSettings.tsx
, so now I removed it from there and placed it in PrivacyPolicy.tsx so that it checks forraw_data_use
and gets filled in anytime the PrivacyPolicy is rendered.Also, to fix the double "to to," I just removed the "to" and "para [ES]" from the backwards compat hack.