Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config #66] create new file #67

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[Config #66] create new file #67

merged 1 commit into from
Feb 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 7, 2024

Adding a new config file

  • Initialized by creating or updating the coressponding issue
  • Auto-generated by create-pull-request

Copy link
Contributor

@sebastianbarry sebastianbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abby-Wheelis Do you think these empty values will be okay for the research questions?

"research_questions": [
"Travel behavior using e-bikes?",
"Barriers to e-bike use and adoption in Southwest DC?",
""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK, it could look odd with an empty string plugged into the text, the safest bet might be to just take those out so the list has a length of 2, but I'm not sure it matters. If you test in the devapp you could see how it looks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing, I realized that we are not currently even using the research_questions field in the app:
Screenshot 2024-02-07 at 3 27 53 PM

When compared to why_we_collect:
Screenshot 2024-02-07 at 3 28 02 PM

Pictures of my testing

Simulator Screenshot - iPhone 13 - 2024-02-07 at 15 25 00 Simulator Screenshot - iPhone 13 - 2024-02-07 at 15 24 46
Simulator Screenshot - iPhone 13 - 2024-02-07 at 15 24 42 Simulator Screenshot - iPhone 13 - 2024-02-07 at 15 24 07

One thing I noticed, this section is written weirdly:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these 2 things sort of go together (both are changes that would affect the consent-text.html files, should I put up a PR to fix these 2 things? @shankari how would we want to include the research questions into the consent text?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which are the two things?
The research questions were in the consent text earlier - you can look at the snapshots back in May to see what the consent looked like then. There is also no consent-text.html any more so I am not sure what this means.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shankari To answer your question about which are the two things:

  1. Put the research questions somewhere in the Privacy Policy screen on the app Me and @Abby-Wheelis met today and decided that this change is unnecessary for 2 reasons: (1) the research_questions field in the config, while is not being used in the app, is being used in the program join pages, and (2) the Privacy policy on the app is already long enough, adding more to it would just muddle it further
  2. The textual glitch I showed in my screenshots on the Privacy policy screen above: "Program Administrators from Energy Administration at District of Colombia Department of Energy and Environment to , and NREL OpenPATH developers for debugging" @Abby-Wheelis 's phone on the production version of NREL-commute is not showing this, but there are emojis there, so this could be a regression from my accessibility changes. I am looking into why my emulator is showing this way

"research_questions": [
"¿Comportamiento de viaje con bicicletas eléctricas?",
"¿Barreras para el uso y la adopción de bicicletas eléctricas en el suroeste de DC?",
""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

@shankari shankari merged commit 19b0020 into main Feb 9, 2024
@shankari
Copy link
Contributor

shankari commented Feb 9, 2024

@jgu2 for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants