Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

French translation for the readme.md file #7457

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

m1-gl
Copy link

@m1-gl m1-gl commented Dec 1, 2019

Proposal of a french translation for the readme.md file. This translation can be accessed by a link in the original file to a new file named readme.fr.md.

@luolong
Copy link

luolong commented Dec 3, 2019

@FroMage Maybe you can review this french translation!

Copy link

@danielleberre danielleberre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a few typos.

README.fr.md Outdated Show resolved Hide resolved
README.fr.md Outdated Show resolved Hide resolved
README.fr.md Outdated Show resolved Hide resolved
README.fr.md Outdated Show resolved Hide resolved
README.fr.md Outdated Show resolved Hide resolved
Copy link
Contributor

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a few fixes as suggestions.
If you could accept suggestions proposed by @danielleberre it would be great.

Last point: After accepting the suggestions, could you please rebase your PR with signed commits. Your email address used in the commit should be the one used in your Eclipse Contributor Agreement (ECA). If you never signed an Eclipse ECA, just have a look here for more information: https://www.eclipse.org/legal/ECA.php and proceed with ECA here: https://accounts.eclipse.org/user/eca

It should be quite straightforward.

README.fr.md Outdated Show resolved Hide resolved
README.fr.md Outdated Show resolved Hide resolved
README.fr.md Outdated Show resolved Hide resolved
README.fr.md Outdated Show resolved Hide resolved
m1-gl and others added 9 commits December 6, 2019 14:28
Accepted typos fix proposals

Co-Authored-By: Daniel Le Berre <daniel.leberre@cril.fr>
Accepted typo fix proposals

Co-Authored-By: Daniel Le Berre <daniel.leberre@cril.fr>
Accepted typo fix proposals

Co-Authored-By: Daniel Le Berre <daniel.leberre@cril.fr>
Accepted typo fix proposals

Co-Authored-By: Daniel Le Berre <daniel.leberre@cril.fr>
Accepted typo fix proposals

Co-Authored-By: Daniel Le Berre <daniel.leberre@cril.fr>
Accepted a fix for the translation

Co-Authored-By: David Festal <dfestal@redhat.com>
Accepted a fix for the translation

Co-Authored-By: David Festal <dfestal@redhat.com>
Accepted a fix for the translation

Co-Authored-By: David Festal <dfestal@redhat.com>
Accepted a fix for the translation

Co-Authored-By: David Festal <dfestal@redhat.com>
@m1-gl
Copy link
Author

m1-gl commented Dec 6, 2019

I accepted every suggestion and signed the eclipse ECA. I also changed my github settings to set the same mail address used in my eclipse account as my public email instead of the mail address set by default but it does not change on the "re-validate" page, it still shows the automatically attributed mail github ending in .noreply

@davidfestal mentioned a PR rebase, I have been searching how to do it but have been unsuccessful so far. How should I proceed ?

Copy link

@Kevin-DDR Kevin-DDR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those changes seem pertinent

@Voiteh
Copy link
Contributor

Voiteh commented Dec 14, 2019

@m1-gl I guess You need to sign-off all commits. I would close this pull request, reset all changes, commit it again with sign-off and pull request again. I don't any know better approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants