-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: branding data merge #1297
fix: branding data merge #1297
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 : it looks like Could you please check and remove it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
==========================================
+ Coverage 91.54% 91.60% +0.05%
==========================================
Files 498 498
Lines 45449 45447 -2
Branches 3157 3164 +7
==========================================
+ Hits 41605 41630 +25
+ Misses 3816 3783 -33
- Partials 28 34 +6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Thanks. I have removed it. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1297 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1297", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1297 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1297", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.19 :: dashboard_3.x/618: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8599: Console, Changes, Git Data |
Build 3.19 :: push-latest-container-to-quay_3.x/5061: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8705: dashboard : 3.x :: Build 66449178 : quay.io/devspaces/dashboard-rhel9:3.19-6 |
Build 3.19 :: update-digests_3.x/8431: Console, Changes, Git Data |
Build 3.19 :: dashboard_3.x/618: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8599 triggered |
Build 3.19 :: operator-bundle_3.x/4311: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8601: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8707: devspaces-operator-bundle : 3.x :: Failed in 66449929 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
This PR fixes the branding data merge.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
It needs for https://issues.redhat.com/browse/CRW-7935