Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: branding data merge #1297

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: branding data merge #1297

merged 2 commits into from
Jan 22, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 21, 2025

What does this PR do?

This PR fixes the branding data merge.

Screenshot/screencast of this PR

Знімок екрана 2025-01-21 о 19 32 34

What issues does this PR fix or reference?

It needs for https://issues.redhat.com/browse/CRW-7935

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jan 21, 2025

Click here to review and test in web IDE: Contribute

@dmytro-ndp
Copy link
Contributor

@olexii4 : it looks like startWorkspaceFromGit property is not needed anymore in main branch.

Could you please check and remove it?

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (dbf085e) to head (0c7b963).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
+ Coverage   91.54%   91.60%   +0.05%     
==========================================
  Files         498      498              
  Lines       45449    45447       -2     
  Branches     3157     3164       +7     
==========================================
+ Hits        41605    41630      +25     
+ Misses       3816     3783      -33     
- Partials       28       34       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Copy link
Contributor Author

olexii4 commented Jan 21, 2025

@olexii4 : it looks like startWorkspaceFromGit property is not needed anymore in main branch.

Could you please check and remove it?

Thanks. I have removed it.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1297

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1297", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1297

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1297", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit c8062f1 into main Jan 22, 2025
21 checks passed
@olexii4 olexii4 deleted the CRW-7935 branch January 22, 2025 13:35
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/618: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/618: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8599 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8707: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 66449929 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants