Fix to make docan frame length configurable#364
Closed
hans-guenterkothgasserbmw wants to merge 1 commit intoeclipse-openbsw:mainfrom
Closed
Fix to make docan frame length configurable#364hans-guenterkothgasserbmw wants to merge 1 commit intoeclipse-openbsw:mainfrom
hans-guenterkothgasserbmw wants to merge 1 commit intoeclipse-openbsw:mainfrom
Conversation
The CAN frames are configurable for CAN (8 bytes) and CAN-FD (64 bytes). But in DoCan is the frame length for diagnostic always 8 Byte. This leads to not responded diagnostic request if CAN-FD is configured. To solve this the frame length for diagnostic must also be configurable.
hans-guenterkothgasserbmw
force-pushed
the
docan-frame-configurable
branch
from
6154997 to
a6f83a2
Compare
rolandreichweinbmw
approved these changes
Feb 6, 2026
rolandreichweinbmw
requested review from
christian-schilling and
matthiaskessler
Contributor
|
Already solved via handling of test message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CAN frames are configurable for CAN (8 bytes) and CAN-FD (64 bytes). But in DoCan is the frame length for diagnostic always 8 Byte. This leads to not responded diagnostic request if CAN-FD is configured. To solve this the frame length for diagnostic shall use the same configuration as the CAN frame.