Find/replace overlay: store search in history when leaving overlay #2291 #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jukzi fyi |
Test Results 1 815 files ±0 1 815 suites ±0 1h 32m 29s ⏱️ - 4m 30s For more details on these failures, see this check. Results for commit b3e2058. ± Comparison against base commit fe9d7e2. ♻️ This comment has been updated with latest results. |
…lipse-platform#2291 The find/replace overlay only stores a search input in the history when an explicit search operation (forward/backward/all search) is performed. In case only an incremental search (via search-as-you-type) is performed, this input will not be added to the history. In some cases, no explicit search is executed but the final result of a search-as-you-type input is sufficient for the user. Since this final result, after they finished typing, also represented a relevant search input, it should be added to the history. This change addresses the issue by adding a search input to the history also when the overlay is left, i.e., the focus is moved to somewhere else, such as the target editor or some other view. Fixes eclipse-platform#2291
HeikoKlare
force-pushed
the
issue-2291
branch
from
40e11a7
to
b3e2058
Compare
|
Failing test is unrelated and already documented: #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The find/replace overlay only stores a search input in the history when an explicit search operation (forward/backward/all search) is performed. In case only an incremental search (via search-as-you-type) is performed, this input will not be added to the history. In some cases, no explicit search is executed but the final result of a search-as-you-type input is sufficient for the user. Since this final result, after they finished typing, also represented a relevant search input, it should be added to the history.
This change addresses the issue by adding a search input to the history also when the overlay is left, i.e., the focus is moved to somewhere else, such as the target editor or some other view.
Fixes #2291