Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find/replace overlay: store search in history when leaving overlay #2291 #2296

Merged
merged 1 commit into from
Sep 19, 2024

Commits on Sep 19, 2024

  1. Find/replace overlay: store search in history when leaving overlay ec…

    …lipse-platform#2291
    
    The find/replace overlay only stores a search input in the history when
    an explicit search operation (forward/backward/all search) is performed.
    In case only an incremental search (via search-as-you-type) is
    performed, this input will not be added to the history. In some cases,
    no explicit search is executed but the final result of a
    search-as-you-type input is sufficient for the user. Since this final
    result, after they finished typing, also represented a relevant search
    input, it should be added to the history.
    
    This change addresses the issue by adding a search input to the history
    also when the overlay is left, i.e., the focus is moved to somewhere
    else, such as the target editor or some other view.
    
    Fixes eclipse-platform#2291
    HeikoKlare committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b3e2058 View commit details
    Browse the repository at this point in the history