Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run the automatic URL scheme registration in Development Mode #2302

Conversation

BeckerWdf
Copy link
Contributor

If the IDE is running in "Development Mode" it doesn't make sense to run this registration job.

Contributes to:
#2245

@jukzi
Copy link
Contributor

jukzi commented Sep 20, 2024

I have no clue what that Registration is all about so i am not eligible to vote.

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Test Results

 1 815 files   1 815 suites   1h 31m 16s ⏱️
 7 699 tests  7 471 ✅ 228 💤 0 ❌
24 258 runs  23 511 ✅ 747 💤 0 ❌

Results for commit c8b75c2.

♻️ This comment has been updated with latest results.

@sratz sratz changed the title Don't run the automatic registration in Development Mode Don't run the automatic URL scheme registration in Development Mode Sep 20, 2024
@BeckerWdf BeckerWdf added this to the 4.34 M1 milestone Sep 20, 2024
@BeckerWdf BeckerWdf self-assigned this Sep 20, 2024
@BeckerWdf BeckerWdf force-pushed the not_run_link_handler_registration_in_dev_mode branch from 665052a to 713b15b Compare September 20, 2024 10:45
@BeckerWdf BeckerWdf force-pushed the not_run_link_handler_registration_in_dev_mode branch from 713b15b to b0ad5f7 Compare September 23, 2024 06:08
If the IDE is running in "Development Mode" it doesn't make sense to
run this registration job.

Contributes to:
eclipse-platform#2245
@BeckerWdf BeckerWdf force-pushed the not_run_link_handler_registration_in_dev_mode branch from b0ad5f7 to c8b75c2 Compare September 24, 2024 06:46
@BeckerWdf BeckerWdf merged commit 0986115 into eclipse-platform:master Sep 24, 2024
16 checks passed
@BeckerWdf BeckerWdf deleted the not_run_link_handler_registration_in_dev_mode branch September 24, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants