Skip to content

fix: remove obsolete TODOs and doc comment in worker.rs#65

Closed
Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Lukasz-Juranek:fix/remove-obsolete-todos-and-unused-prio
Closed

fix: remove obsolete TODOs and doc comment in worker.rs#65
Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Lukasz-Juranek:fix/remove-obsolete-todos-and-unused-prio

Conversation

@Lukasz-Juranek
Copy link
Contributor

Summary

  • Remove obsolete TODO doc comment block on impl Worker that listed stale items (shutdown, join logic, prio & affinity, migrate to iceoryxbb2)
  • Remove obsolete inline TODO comments in next_task() and maybe_run_driver(), including one referencing the old internal repo issue tracker
  • The unused _prio parameter mentioned in the issue was already removed in a prior change

Closes #11

Test plan

  • bazel test //... passes (8/8 tests) before and after the change
  • bazel build //... succeeds
  • Format checks pass (rustfmt, ruff, buildifier, yamlfmt)

🤖 Generated with Claude Code

@github-actions
Copy link

github-actions bot commented Feb 14, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 9511a77b-56f7-4fef-8b91-c9c1f4921455
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.14 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.5.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (24 packages loaded, 9 targets configured)

Analyzing: target //:license-check (70 packages loaded, 9 targets configured)

Analyzing: target //:license-check (83 packages loaded, 21 targets configured)

Analyzing: target //:license-check (129 packages loaded, 1701 targets configured)

Analyzing: target //:license-check (133 packages loaded, 2518 targets configured)

Analyzing: target //:license-check (141 packages loaded, 2577 targets configured)

Analyzing: target //:license-check (141 packages loaded, 2577 targets configured)

Analyzing: target //:license-check (142 packages loaded, 2701 targets configured)

Analyzing: target //:license-check (146 packages loaded, 4713 targets configured)

INFO: Analyzed target //:license-check (146 packages loaded, 4716 targets configured).
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 209 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[15 / 17] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[16 / 17] [Prepa] Building license.check.license_check.jar ()
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.908s, Critical Path: 2.74s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

Remove obsolete TODO comments from worker.rs:
- Remove "Remove hardcoded values into global config" TODO in next_task()
- Remove TODO referencing old internal repo issue #153 in next_task()
- Remove "Ensure it's power of 2" TODO in maybe_run_driver()

The _prio parameter referenced in the issue was already removed
in a prior change.

Closes eclipse-score#11

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: obsolete TODOs and parameter in worker.rs

1 participant