fix: remove obsolete TODOs and doc comment in worker.rs#65
Closed
Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Closed
fix: remove obsolete TODOs and doc comment in worker.rs#65Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Lukasz-Juranek wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Remove obsolete TODO comments from worker.rs: - Remove "Remove hardcoded values into global config" TODO in next_task() - Remove TODO referencing old internal repo issue #153 in next_task() - Remove "Ensure it's power of 2" TODO in maybe_run_driver() The _prio parameter referenced in the issue was already removed in a prior change. Closes eclipse-score#11 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9f4747a to
5f4070e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
impl Workerthat listed stale items (shutdown, join logic, prio & affinity, migrate to iceoryxbb2)next_task()andmaybe_run_driver(), including one referencing the old internal repo issue tracker_prioparameter mentioned in the issue was already removed in a prior changeCloses #11
Test plan
bazel test //...passes (8/8 tests) before and after the changebazel build //...succeeds🤖 Generated with Claude Code