Skip to content

fix: remove obsolete TODOs and doc comment in worker.rs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lukasz-Juranek wants to merge 1 commit into from
Closed

fix: remove obsolete TODOs and doc comment in worker.rs #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/kyron/src/scheduler/workers/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,6 @@ struct WorkerInner {
next_task_tick: u64,
}

///
/// Async Worker implementation
///
/// TODO:
/// - shutdown
/// - join logic
/// - prio & affinity
/// - migrate to iceoryxbb2 once we know details
/// - ....
///
///
impl Worker {
pub(crate) fn new(id: WorkerId, engine_has_safety_worker: bool) -> Self {
Self {
Expand Down Expand Up @@ -275,10 +264,9 @@ impl WorkerInner {

fn next_task(&mut self) -> (Option<TaskRef>, bool) {
let mut should_notify = false;
//TODO: Remove hardcoded values into global config
if self.next_task_tick % 16 == 0 {
// It's time to check if we have work in global queue
should_notify = self.try_take_global_work_internal() > 0; //TODO(https://github.com/qorix-group/inc_orchestrator_internal/issues/153) - try semantic missing
should_notify = self.try_take_global_work_internal() > 0;
}

(self.producer_consumer.pop(), should_notify)
Expand Down
Loading