Enable querier for zenoh-pico #380
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'bug', 'internal', 'dependencies', 'enhancement', 'documentation', 'new feature'} |
sashacmc
force-pushed
the
querier_pico_support
branch
2 times, most recently
from
149558c to
63035d5
Compare
sashacmc
force-pushed
the
querier_pico_support
branch
from
63035d5 to
0f77d1b
Compare
|
Please do not forget to update cmake files for corresponding tests/examples. |
|
LGTM, except that in pico querier is only under Z_FEATURE_UNSTABLE_API and not under ZENOHPICO_FEATURE_QUERY (as z_get), looks a bit strange given that both z_put and Publisher are under the same ZENOHPICO_FEATURE_PUBLICATION. |
DenisBiryukov91
approved these changes
Jan 24, 2025
sashacmc
force-pushed
the
querier_pico_support
branch
3 times, most recently
from
d43ec9e to
3fb57aa
Compare
sashacmc
force-pushed
the
querier_pico_support
branch
from
3fb57aa to
b5a3fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add querier support for zenoh-pico, because it already avaliable
eclipse-zenoh/zenoh-pico#858