Feature/sd 63148 rr monthly #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sebvi
reviewed
Nov 21, 2023
Comment on lines
-83
to
93
| productDefinitionTemplateNumber = 8; | ||
| productDefinitionTemplateNumber = 0; | ||
| } | ||
| oper = { | ||
| productDefinitionTemplateNumber = 0; | ||
| productDefinitionTemplateNumber = 8; | ||
| } |
There was a problem hiding this comment.
is it just a swap but effectively doing the same thing?
There was a problem hiding this comment.
yes, not sure how it happened, just sort of beautification to keep the order
sebvi
reviewed
Nov 21, 2023
definitions/grib2/products_crra.def
Outdated
| productDefinitionTemplateNumber = 8; | ||
| outerLoopTypeOfTimeIncrement = 1; | ||
| outerLoopLengthOfTimeRange = 24; | ||
| } | ||
| } : no_copy; |
There was a problem hiding this comment.
I would make the marsStream concept read only as we don't want anyone to set it directly
|
Can you please sign the CLA? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.