Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sd 63148 rr monthly #178

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Feature/sd 63148 rr monthly #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b116f9f
carra daily/monthly products SD-63148
richard-mladek Nov 21, 2023
22f6855
param names beautification
richard-mladek Nov 21, 2023
c17d32f
changing streams for class=rr to read only
richard-mladek Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 53 additions & 4 deletions definitions/grib2/products_crra.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,24 +75,73 @@ concept marsType(unknown) {
}
}

# get the values from the 1st most outer loop which matter!
# aarays should be implemented in ecCodes as for bufr i.e. outerLoopLengthOfTimeRange[0] => #0#lengthOfTimeRange
meta outerLoopLengthOfTimeRange element(lengthOfTimeRange, 0);
meta outerLoopTypeOfStatisticalProcessing element(typeOfStatisticalProcessing, 0);
meta outerLoopTypeOfTimeIncrement element(typeOfTimeIncrement, 0);

# See GRIB-205 re no_copy
# Cannot use typeOfProcessedData for stream. See GRIB-911
concept marsStream(unknown) {

oper = {
productDefinitionTemplateNumber = 8;
productDefinitionTemplateNumber = 0;
}
oper = {
productDefinitionTemplateNumber = 0;
productDefinitionTemplateNumber = 8;
}
Comment on lines -83 to 93
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it just a swap but effectively doing the same thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, not sure how it happened, just sort of beautification to keep the order


enda = {
productDefinitionTemplateNumber = 11;
}
enda = {
productDefinitionTemplateNumber = 1;
}
} : no_copy;
moda = {
productDefinitionTemplateNumber = 8;
outerLoopTypeOfTimeIncrement = 1;
}
# avgd, mind, maxd
dame = {
productDefinitionTemplateNumber = 8;
outerLoopTypeOfTimeIncrement = 1;
outerLoopLengthOfTimeRange = 21;
}
# accumd
dame = {
productDefinitionTemplateNumber = 8;
outerLoopTypeOfTimeIncrement = 1;
outerLoopLengthOfTimeRange = 24;
}
} : no_copy,read_only;

alias mars.stream = marsStream;
alias mars.type = marsType;

if (marsStream is "moda") {

meta verificationDate g1verificationdate(dataDate, dataTime, outerLoopLengthOfTimeRange) : read_only;
meta monthlyVerificationDate g1monthlydate(verificationDate) : no_copy;
alias mars.date = monthlyVerificationDate;

unalias mars.time;
unalias mars.step;
}

if (marsStream is "dame") {

if (!(outerLoopTypeOfStatisticalProcessing == 3 || outerLoopTypeOfStatisticalProcessing == 2)) {
# not mind or maxd
alias mars.date = validityDate;
}

if (outerLoopLengthOfTimeRange == 24) {
# accumd
meta verificationDate g1verificationdate(dataDate, dataTime, outerLoopLengthOfTimeRange) : read_only;
alias mars.date = verificationDate;

}

unalias mars.time;
unalias mars.step;
}
1 change: 1 addition & 0 deletions definitions/mars/stream.table
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
1097 smma Seasonal monthly means anomalies
1098 clte Climate run output
1099 clmn Climate run monthly means output
1100 dame Daily means
1110 seap Sensitive area prediction
1120 eefh Extended ensemble forecast hindcast
1121 eehs Extended ensemble forecast hindcast statistics
Expand Down
Loading