Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback interface class for serverside callback registration #63

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

ChrisspyB
Copy link
Member

Simple abstraction of the callback registration to allow registration of callbacks with the StoreHandler, rather than just an FDB object. Required for gribjump plugin on the databridge store servers, which at no point create an FDB object.

@ChrisspyB
Copy link
Member Author

ChrisspyB commented Jan 6, 2025

Related: ecmwf/gribjump#37. Since this change alters the callback interface slightly, gribjump tests will fail on the CI. This is expected.

@ChrisspyB
Copy link
Member Author

Not ready for merge yet, some testing to do. But I am optimisitic.

@ChrisspyB ChrisspyB marked this pull request as ready for review January 7, 2025 14:16
@ChrisspyB
Copy link
Member Author

Seems to work, ready to review

@ChrisspyB ChrisspyB requested a review from Ozaq January 8, 2025 12:17
@danovaro danovaro changed the base branch from remoteFDB to develop January 14, 2025 09:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.21%. Comparing base (c6e8b9e) to head (2acd0cf).
Report is 222 commits behind head on develop.

Files with missing lines Patch % Lines
src/fdb5/remote/server/StoreHandler.cc 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #63      +/-   ##
===========================================
- Coverage    64.50%   61.21%   -3.30%     
===========================================
  Files          238      265      +27     
  Lines        13844    14935    +1091     
  Branches      1334     1474     +140     
===========================================
+ Hits          8930     9142     +212     
- Misses        4914     5793     +879     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danovaro danovaro merged commit 22e9a44 into develop Jan 14, 2025
120 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants