Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fdb callback interface #37

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

ChrisspyB
Copy link
Member

No description provided.

@ChrisspyB
Copy link
Member Author

Depends on ecmwf/fdb#63 , which updates the callback interface

@ChrisspyB
Copy link
Member Author

ChrisspyB commented Jan 6, 2025

TODO:

  • Update fdb version requirement before merging.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.68%. Comparing base (6c2e44f) to head (cc3d323).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #37      +/-   ##
===========================================
+ Coverage    61.66%   61.68%   +0.02%     
===========================================
  Files           89       89              
  Lines         4596     4599       +3     
  Branches       500      500              
===========================================
+ Hits          2834     2837       +3     
  Misses        1762     1762              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB
Copy link
Member Author

TODO:

* Update fdb version requirement before merging.

Cannot until FDB updates tags. Merging anyway

@ChrisspyB ChrisspyB merged commit fc689d8 into develop Jan 14, 2025
104 checks passed
@ChrisspyB ChrisspyB deleted the feature/serverside-callback branch January 14, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants