refactor: Change casing on SwapStyle (and other htmx enums) for correct serialization #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the naming convention of the SwapStyle enum to match htmx attribute casing. This change affects several files where this enum is used, including HtmxConfig.cs, SwapStyleEnumConverter.cs, and various test files. The refactor allows correct serialization if used in blazor markup.
Updated the reference to ScrollBehavior.smooth in the HtmxConfig class.
egil
approved these changes
May 15, 2024
|
I think git would like you to sign your commits. Probably way merging is blocked. |
Added remarks to the ScrollBehavior, ScrollDirection, SwapStyle, and TriggerQueueOption enums. These remarks clarify that the casing of these values matches htmx attributes for direct use in markup. Also added a specific remark for Default SwapStyle indicating it cannot be used directly in markup.
egil
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
Also alters other htmx enums to match style:
ScrollBehavior (Smooth/Auto to smooth/auto)
ScrollDirection (Top/Bottom to top/bottom)
TriggerQueueOption (First/Last/All/None to first/last/all/none)
TriggerTiming (left as is - this is technically not an htmx value but used only by Htmxor)