Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Change casing on SwapStyle (and other htmx enums) for correct serialization #54

Merged
merged 4 commits into from
May 15, 2024
Merged

refactor: Change casing on SwapStyle (and other htmx enums) for correct serialization #54

merged 4 commits into from
May 15, 2024

Commits on May 15, 2024

  1. refactor: Update SwapStyle enum naming convention 

    Updated the naming convention of the SwapStyle enum to match htmx attribute casing. This change affects several files where this enum is used, including HtmxConfig.cs, SwapStyleEnumConverter.cs, and various test files. The refactor allows correct serialization if used in blazor markup.
    @tanczosm
    tanczosm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    559178c View commit details
    Browse the repository at this point in the history

  2. refactor: update other htmx enum value names to match SwapStyle

    @tanczosm
    tanczosm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    412df2b View commit details
    Browse the repository at this point in the history

  3. refactor: Update reference in HtmxConfig class 

    Updated the reference to ScrollBehavior.smooth in the HtmxConfig class.
    @tanczosm
    tanczosm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f599434 View commit details
    Browse the repository at this point in the history

  4. docs: Add remarks to enum definitions 

    Added remarks to the ScrollBehavior, ScrollDirection, SwapStyle, and TriggerQueueOption enums. These remarks clarify that the casing of these values matches htmx attributes for direct use in markup. Also added a specific remark for Default SwapStyle indicating it cannot be used directly in markup.
    @tanczosm
    tanczosm committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8a0bbf6 View commit details
    Browse the repository at this point in the history