Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Resolver serialization + ball ball friction sub models #171

Merged
merged 41 commits into from
Jan 8, 2025

Cattrs structuring leads to fallback to default

1e23f82
Select commit
Loading
Failed to load commit list.
Merged

Refactor Resolver serialization + ball ball friction sub models #171

Cattrs structuring leads to fallback to default
1e23f82
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 0s

44.74% (+0.52%) compared to 0e89b7f

View this Pull Request on Codecov

44.74% (+0.52%) compared to 0e89b7f

Details

Codecov Report

Attention: Patch coverage is 73.97260% with 57 lines in your changes missing coverage. Please review.

Project coverage is 44.74%. Comparing base (0e89b7f) to head (1e23f82).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pooltool/physics/resolve/__init__.py 11.42% 31 Missing ⚠️
pooltool/physics/resolve/resolver.py 53.48% 20 Missing ⚠️
pooltool/serialize/convert.py 50.00% 4 Missing ⚠️
pooltool/physics/resolve/ball_ball/friction.py 93.54% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   44.22%   44.74%   +0.52%     
==========================================
  Files         127      129       +2     
  Lines        8554     8684     +130     
==========================================
+ Hits         3783     3886     +103     
- Misses       4771     4798      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov