-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Resolver serialization + ball ball friction sub models #171
Conversation
…onfigurable friction parameters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 44.22% 44.74% +0.52%
==========================================
Files 127 129 +2
Lines 8554 8684 +130
==========================================
+ Hits 3783 3886 +103
- Misses 4771 4798 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Put it in the right place - Name it as your model name
Looks good! And I think the inclusion of the Alciatore friction model will give better results for Mathavan. |
- (Since I'm creating a ball-cushion model, I add entries to BallLCushionModel (linear) and BallCCushionModel (circular))
- Circular and Linear cushions - Note that the circular collision model also must be registered
Got around to adding new instructions for adding custom physics. Merging this now. Hopefully all goes well! |
Instead of serializing a dumbed down version of
Resolver
viaResolverConfig
,Resolver
is itself serialized (as~/.config/pooltool/physics/resolver.yaml
).Summary of changes:
get_X_model
functions are removed. It was an obfuscating abstraction.model
attribute. This is used as a cattrs structuring directive.The default resolver.yaml now looks like this: