Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.9] docs: Removes // from Node.js link #11560

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[8.9] docs: Removes // from Node.js link #11560

merged 1 commit into from
Aug 31, 2023

Conversation

KOTungseth
Copy link
Contributor

Changes {apm-node-ref-v}//configuration.html#capture-body to {apm-node-ref-v}/configuration.html#capture-body

@KOTungseth
[8.9] docs: Removes // from Node.js link
7d43e7f 
Changes `{apm-node-ref-v}//configuration.html#capture-body` to `{apm-node-ref-v}/configuration.html#capture-body`
@KOTungseth KOTungseth self-assigned this Aug 31, 2023
@KOTungseth KOTungseth added docs Team:Docs Label for the Observability docs team v8.9.0 labels Aug 31, 2023
bmorelli25
bmorelli25 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve, but unfortunately I don't have permission to merge.

@bmorelli25 bmorelli25 mentioned this pull request Aug 31, 2023
Closed
@kruskall kruskall merged commit a4bda6f into elastic:8.9 Aug 31, 2023
5 checks passed
@kruskall
Copy link
Member

@KOTungseth Thanks! 😄

For future reference: I think it's enough to open a PR for main and then add labels to backport to older versions. Mergifyio should take care of opening the other PRs.

@KOTungseth KOTungseth deleted the patch-8 branch August 31, 2023 18:20
kruskall pushed a commit to kruskall/apm-server that referenced this pull request Aug 31, 2023
@KOTungseth @kruskall
[8.9] docs: Removes // from Node.js link (elastic#11560)
aeacf45 
Changes `{apm-node-ref-v}//configuration.html#capture-body` to `{apm-node-ref-v}/configuration.html#capture-body`
kruskall pushed a commit to kruskall/apm-server that referenced this pull request Aug 31, 2023
@KOTungseth @kruskall
[8.9] docs: Removes // from Node.js link (elastic#11560)
9e8d236 
Changes `{apm-node-ref-v}//configuration.html#capture-body` to `{apm-node-ref-v}/configuration.html#capture-body`
@kruskall kruskall mentioned this pull request Aug 31, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@kruskall kruskall kruskall approved these changes

Assignees

@KOTungseth KOTungseth

Labels
docs Team:Docs Label for the Observability docs team v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KOTungseth @kruskall @bmorelli25