Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #6475) [helm] reload chart for each example folder #6480

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 6, 2025

What does this PR do?

This PR fixes an issue with the Helm chart examples rendering. Specifically, the Helm chart is now reloaded for each example folder. Previously, the chart was loaded once and reused, which leads to stale data when different examples enable or disable subchart dependencies (spoiler alert for the upcoming kube-state-metrics subchart dependency PR I am working on).

Why is it important?

Reloading the Helm chart for each example folder ensures correctness in the rendered k8s manifests.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

mage helm:renderExamples

Related issues

N/A


This is an automatic backport of pull request #6475 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Jan 6, 2025
@mergify mergify bot requested a review from a team as a code owner January 6, 2025 00:58
@mergify mergify bot requested review from pkoutsovasilis and michel-laterman and removed request for a team January 6, 2025 00:58
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor Author

mergify bot commented Jan 6, 2025

This pull request has not been merged yet. Could you please review and merge it @pkoutsovasilis? 🙏

@jlind23 jlind23 merged commit ef1462a into 8.17 Jan 6, 2025
15 checks passed
@jlind23 jlind23 deleted the mergify/bp/8.17/pr-6475 branch January 6, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants