Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17](backport #6475) [helm] reload chart for each example folder #6480

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[8.17](backport #6475) [helm] reload chart for each example folder #6480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions magefile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3400,12 +3400,7 @@ func (Helm) RenderExamples() error {
settings := cli.New() // Helm CLI settings
actionConfig := &action.Configuration{}

helmChart, err := loader.Load(helmChartPath)
if err != nil {
return fmt.Errorf("failed to load helm chart: %w", err)
}

err = actionConfig.Init(settings.RESTClientGetter(), "default", "",
err := actionConfig.Init(settings.RESTClientGetter(), "default", "",
func(format string, v ...interface{}) {})
if err != nil {
return fmt.Errorf("failed to init helm action config: %w", err)
Expand All @@ -3422,6 +3417,11 @@ func (Helm) RenderExamples() error {
continue
}

helmChart, err := loader.Load(helmChartPath)
if err != nil {
return fmt.Errorf("failed to load helm chart: %w", err)
}

exampleFullPath := filepath.Join(examplesPath, d.Name())

helmValues := make(map[string]any)
Expand Down
Loading