-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.17](backport #5767) Add support for running EDOT inside of running Elastic Agent #6629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b07566b) # Conflicts: # NOTICE.txt # go.mod # go.sum # internal/pkg/agent/application/coordinator/coordinator_test.go # internal/pkg/otel/components.go # internal/pkg/otel/run.go
Cherry-pick of b07566b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to run the EDOT along side the running Elastic Agent.
This connects the EDOT into the coordinator of the Elastic Agent. At any point if any of these top-level keys (
receivers
,processors
,exporters
,extensions
,service
) exist in the configuration or policy for the elastic-agent the EDOT is started. If all of those keys are removed from the configuration or policy then the EDOT is automatically stopped. If any configuration change occurs the updated configuration is passed along to the EDOT to handle.Why is it important?
This allows EDOT configuration to exist inside of the configuration or policy and allow it to work as expected.
Checklist
[ ] I have made corresponding changes to the documentation./changelog/fragments
using the changelog toolDisruptive User Impact
This is an addition and doesn't affect the way the current Elastic Agent runs at all.
How to test this PR locally
Place OTel configuration into the
elastic-agent.yml
:Run
elastic-agent run -e
.Related issues
Closes #5796
This is an automatic backport of pull request #5767 done by Mergify.