Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.1.1, release fixes #159

Merged
merged 1 commit into from
Apr 30, 2024
Merged

version 0.1.1, release fixes #159

merged 1 commit into from
Apr 30, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Apr 30, 2024

  • limit files included in the published package (no need to publish docs and tests)
  • fix release.yml workflow to setup npm login

- limit files included in the published package (no need to publish docs and tests)
- fix release.yml workflow to setup npm login
@trentm trentm requested a review from david-luna April 30, 2024 18:16
@trentm trentm self-assigned this Apr 30, 2024
@trentm
Copy link
Member Author

trentm commented Apr 30, 2024

The 0.1.0 release failed to npm publish, https://github.com/elastic/elastic-otel-node/actions/runs/8899433997/job/24438787165

npm notice 
npm ERR! code ENEEDAUTH
npm ERR! need auth This command requires you to be logged in to https://registry.npmjs.org/
npm ERR! need auth You need to authorize this machine using `npm adduser`
npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2024-04-30T17_58_16_276Z-debug-0.log
Error: Process completed with exit code 1.

This was because the actions/setup-node didn't have the registry-url option that tells it to setup a .npmrc file with npm login auth. See https://github.com/actions/setup-node?tab=readme-ov-file#usage and https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry

@trentm trentm merged commit 1718ee8 into main Apr 30, 2024
12 checks passed
@trentm trentm deleted the trentm/release-0.1.1 branch April 30, 2024 18:19
@trentm
Copy link
Member Author

trentm commented Apr 30, 2024

@trentm
Copy link
Member Author

trentm commented Apr 30, 2024

That attempt failed on generating npm provenance becayuse the repo was still private. I've made the repo public now.

take 2: https://github.com/elastic/elastic-otel-node/actions/runs/8899712600/job/24439813707

@trentm
Copy link
Member Author

trentm commented Apr 30, 2024

That failed again because 'npm pkg fix' pickiness. See #161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants