Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.1.2; apply 'npm pkg fix' changes required by provenance generation #161

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Apr 30, 2024

This is a follow-on from #159

The release attempt failed to 'npm publish' in https://github.com/elastic/elastic-otel-node/actions/runs/8899712600/job/24439813707

npm WARN publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish "repository.url" was normalized to "git+https://github.com/elastic/elastic-otel-java.git"
npm notice 
npm notice 📦  @elastic/opentelemetry-node@0.1.1
...
npm notice total files:   27                                      
npm notice 
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm notice publish Signed provenance statement with source and build information from GitHub Actions
npm notice publish Provenance statement published to transparency log: https://search.sigstore.dev/?logIndex=89932488
npm ERR! code E422
npm ERR! 422 Unprocessable Entity - PUT https://registry.npmjs.org/@elastic%2fopentelemetry-node - Error verifying sigstore provenance bundle: Failed to validate repository information: package.json: "repository.url" is "git+https://github.com/elastic/elastic-otel-java.git", expected to match "https://github.com/elastic/elastic-otel-node" from provenance
npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2024-04-30T18_24_32_156Z-debug-0.log

... because provenance generation is apparently very picky about package.json changes, and the automatic 'npm pkg fix' during 'npm publish' broke that.

@trentm trentm requested a review from david-luna April 30, 2024 18:32
@trentm trentm self-assigned this Apr 30, 2024
@trentm trentm merged commit 5bd5355 into main Apr 30, 2024
13 checks passed
@trentm trentm deleted the trentm/release-0.1.2 branch April 30, 2024 18:40
@trentm
Copy link
Member Author

trentm commented Apr 30, 2024

Third release workflow run attempt will be the charm: https://github.com/elastic/elastic-otel-node/actions/runs/8899975155/job/24440479607

@trentm
Copy link
Member Author

trentm commented Apr 30, 2024

will be the charm

Or not. Still failing:

npm notice 
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm notice publish Signed provenance statement with source and build information from GitHub Actions
npm notice publish Provenance statement published to transparency log: https://search.sigstore.dev/?logIndex=89934205
npm ERR! code E422
npm ERR! 422 Unprocessable Entity - PUT https://registry.npmjs.org/@elastic%2fopentelemetry-node - Error verifying sigstore provenance bundle: Failed to validate repository information: package.json: "repository.url" is "git+https://github.com/elastic/elastic-otel-java.git", expected to match "https://github.com/elastic/elastic-otel-node" from provenance
npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2024-04-30T18_41_41_489Z-debug-0.log

I misdiagnosed the issue here.

@@ -10,7 +10,7 @@
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "https://github.com/elastic/elastic-otel-java.git",
"url": "git+https://github.com/elastic/elastic-otel-java.git",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 'elastic-otel-java.git' correct here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants