Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] Bump Golang version to 1.23.5 #4353

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 24, 2025

Bump golang-version to latest version

Update .go-version

1 file(s) updated with "1.23.5": * .go-version

1.23.5
no GitHub Release found for go1.23.5 on "https://github.com/golang/go"
Update .golangci.yml

1 file(s) updated with "1.23.5": * .golangci.yml

1.23.5
no GitHub Release found for go1.23.5 on "https://github.com/golang/go"
GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@github-actions github-actions bot requested a review from a team as a code owner January 24, 2025 20:05
@github-actions github-actions bot added the backport-skip Skip notification from the automated backport with mergify label Jan 24, 2025
@cmacknz
Copy link
Member

cmacknz commented Jan 24, 2025

#4343 (comment)

This needs a changelog.

Also 8.16 and 8.17 are on outdated versions of Go 1.22.x. We can either backport this there to get the CVE fixes or update to the latest 1.22.

Similarly 7.17 is still on 1.21 and definitely needs an update to either 1.22 and 1.23.

If we are confident 1.23 won't introduce any problems probably simplest to backport this to all of them. I'll add the backport labels for these out of convenience.

That these keep getting closed periodically and recreated with all comments and changes stripped is pretty annoying. @v1v do you know what causes this? Beats and Elastic Agent do the same thing. Probably the GH action is wrong somewhow.

@v1v
Copy link
Member

v1v commented Jan 25, 2025

That these keep getting closed periodically and recreated with all comments and changes stripped is pretty annoying. @v1v do you know what causes this? Beats and Elastic Agent do the same thing. Probably the GH action is wrong somewhow.

I see #4343 was closed and it contains 0 changes.

I'll review it. So far, it seems related to updatecli/updatecli#2039 although it talks about different updatecli pipelines... but the behaviour is certainly the same.

This #4343 (comment) closed the PR as a consequence of https://github.com/elastic/fleet-server/actions/runs/12937148219

As far as I see we have not changed the updatecli version in this project for quite some time... So, my first attempt will be to update it

@github-actions github-actions bot force-pushed the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch from 2f5817f to c4bd292 Compare January 25, 2025 13:35
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
@github-actions github-actions bot force-pushed the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch from 662a130 to 758aea9 Compare January 27, 2025 20:06
@michel-laterman michel-laterman added backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 28, 2025
@michel-laterman
Copy link
Contributor

This needs a changelog.
Also 8.16 and 8.17 are on outdated versions of Go 1.22.x. We can either backport this there to get the CVE fixes or update to the latest 1.22.
Similarly 7.17 is still on 1.21 and definitely needs an update to either 1.22 and 1.23.
If we are confident 1.23 won't introduce any problems probably simplest to backport this to all of them. I'll add the backport labels for these out of convenience.

The 7.17, 8.16, 8.17, and 8.x branches are on go v1.23.1, I've added the changelog entry and backport labels

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@michel-laterman michel-laterman merged commit baed459 into main Jan 28, 2025
9 checks passed
@michel-laterman michel-laterman deleted the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch January 28, 2025 23:31
mergify bot pushed a commit that referenced this pull request Jan 28, 2025
* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml
mergify bot pushed a commit that referenced this pull request Jan 28, 2025
* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml
mergify bot pushed a commit that referenced this pull request Jan 28, 2025
* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml
mergify bot pushed a commit that referenced this pull request Jan 28, 2025
* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml
swiatekm pushed a commit that referenced this pull request Jan 29, 2025
)

* [Automation] Bump Golang version to 1.23.5 (#4353)

* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml

* Fix merge

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
michel-laterman added a commit that referenced this pull request Jan 29, 2025
)

* [Automation] Bump Golang version to 1.23.5 (#4353)

* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml

* Fix merge

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
michel-laterman added a commit that referenced this pull request Jan 29, 2025
* [Automation] Bump Golang version to 1.23.5 (#4353)

* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml

* Fix merge

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
michel-laterman added a commit that referenced this pull request Jan 29, 2025
)

* [Automation] Bump Golang version to 1.23.5 (#4353)

* chore: Update .golangci.yml

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* Add Changelog

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
(cherry picked from commit baed459)

# Conflicts:
#	.go-version
#	.golangci.yml

* Fix merge

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants