packages/apm: remove data streams in 8.15.0 #9949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of elastic/elasticsearch#108860 (due to be released in 8.15.0), the apm-data Elasticsearch plugin is enabled by default and will take care of installing index templates and ingest pipelines for APM; the integration package no longer needs to (nor should) install its own. With this change, the integration package is optional for APM: it is still useful for running with Fleet, but otherwise users may rely on templates/pipelines being set up by Elasticsearch.
axw
force-pushed
the
apm-package-rm-datastreams
branch
from
758a953
to
36d84ba
Compare
endorama
reviewed
May 23, 2024
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| Elastic APM is an application performance monitoring system built on the Elastic Stack. It allows you to monitor software services and applications in real-time, by collecting detailed performance information on response time for incoming requests, database queries, calls to caches, external HTTP requests, and more. | |||
|
|
|||
| The APM integration installs templates and pipelines that validate and process APM data. | |||
There was a problem hiding this comment.
Removing this line obscures what is this integration purpose after these changes. May we replace it instead providing guidance on it's purpose?
There was a problem hiding this comment.
Fair enough, I'll have a think about what to replace it with.
axw
commented
May 24, 2024
Comment on lines
+5
to
+6
| The APM integration enables central management of APM Server with Fleet. | ||
| To learn more, see [Fleet-managed APM Server](https://ela.st/apm-fleet). |
There was a problem hiding this comment.
@simitt FYI I've updated the docs here, and created a new shorted link
💚 Build Succeeded
History
|
|
kruskall
approved these changes
May 24, 2024
endorama
approved these changes
May 24, 2024
This was referenced May 28, 2024
crespocarlos
added a commit
to elastic/kibana
that referenced
this pull request
May 28, 2024
…184343) closes [#184333](#184333) ## Summary This PR updates the index template names that the diagnostics page verifies the existence of. After the changes made in the [APM package](elastic/integrations#9949), to favor APM indices and ingest pipelines configured by elasticsearch, the index templates now have a `@template` suffix. eg: `metrics-apm.service_destination.1m` is now `metrics-apm.service_destination.1m@template` <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/4608da37-679a-411c-85c4-409b2af62cec"> <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/837c8ae0-2c92-4763-811c-22fc619ba5f6"> **When no indices are found** <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/33d7264a-dc90-49a0-a3f4-f169dcbda861"> ### How to test - Start a local ES and kibana instance - navigate to `/apm/diagnostics/index-templates?rangeFrom=now-15m&rangeTo=now` --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
…lastic#184343) closes [elastic#184333](elastic#184333) ## Summary This PR updates the index template names that the diagnostics page verifies the existence of. After the changes made in the [APM package](elastic/integrations#9949), to favor APM indices and ingest pipelines configured by elasticsearch, the index templates now have a `@template` suffix. eg: `metrics-apm.service_destination.1m` is now `metrics-apm.service_destination.1m@template` <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/4608da37-679a-411c-85c4-409b2af62cec"> <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/837c8ae0-2c92-4763-811c-22fc619ba5f6"> **When no indices are found** <img width="709" alt="image" src="https://github.com/elastic/kibana/assets/2767137/33d7264a-dc90-49a0-a3f4-f169dcbda861"> ### How to test - Start a local ES and kibana instance - navigate to `/apm/diagnostics/index-templates?rangeFrom=now-15m&rangeTo=now` --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
bmorelli25
pushed a commit
to bmorelli25/integrations
that referenced
this pull request
Jun 3, 2024
* packages/apm: remove data streams in 8.15.0 As of elastic/elasticsearch#108860 (due to be released in 8.15.0), the apm-data Elasticsearch plugin is enabled by default and will take care of installing index templates and ingest pipelines for APM; the integration package no longer needs to (nor should) install its own. With this change, the integration package is optional for APM: it is still useful for running with Fleet, but otherwise users may rely on templates/pipelines being set up by Elasticsearch. * Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
As of elastic/elasticsearch#108860 (due to be released in 8.15.0), the apm-data Elasticsearch plugin is enabled by default and will take care of installing index templates and ingest pipelines for APM; the integration package no longer needs to (nor should) install its own.
With this change, the integration package is optional for APM: it is still useful for running with Fleet, but otherwise users may rely on templates/pipelines being set up by Elasticsearch.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
elastic/apm-server#11529